Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for GtResourceLoad list column #710

Merged
merged 12 commits into from
May 24, 2022
Merged

Fix for GtResourceLoad list column #710

merged 12 commits into from
May 24, 2022

Conversation

tarjeieo
Copy link
Member

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Fix for #610. Changed field type to allow search to create/use managed props.

How to test

Please describe how someone else (a regular user without coding skills) can test this PR. In the form of a numbered list and checkboxes for Jan when the testing period occurs.

Example:

  1. Create a new site
  2. Create resource allocation entry and allocate a percentage
  3. Observe that it shows up in the portfolio resource allocation view (after some minutes)

Relevant issues (if applicable)

#610

💔Thank you!

@tarjeieo tarjeieo requested review from olemp and okms as code owners May 12, 2022 22:37
@tarjeieo tarjeieo linked an issue May 12, 2022 that may be closed by this pull request
Resource allocation displays 0% no matter the input #610
Closed
@tarjeieo tarjeieo self-assigned this May 12, 2022
@tarjeieo tarjeieo added this to the 1.6.0 milestone May 12, 2022
@tarjeieo tarjeieo added the bug Something isn't working label May 12, 2022
@tarjeieo tarjeieo marked this pull request as draft May 13, 2022 09:32
@tarjeieo tarjeieo marked this pull request as ready for review May 23, 2022 11:31
@tarjeieo tarjeieo mentioned this pull request May 23, 2022
Closed
okms
okms approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@okms okms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Love those extra tabs

@tarjeieo tarjeieo merged commit 080b041 into dev May 24, 2022
@tarjeieo tarjeieo deleted the 610-fieldtype branch May 24, 2022 07:39
Remi749 added a commit that referenced this pull request Jun 27, 2022
@Remi749 @olemp @tarjeieo
1.6.0 prep (#738)
6dc2381 
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Remi749 added a commit that referenced this pull request Jun 27, 2022
@Remi749 @olemp @tarjeieo
v1.6.0 (#739)
a593dd5 
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

* 1.6.0

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Remi749 added a commit that referenced this pull request Jun 29, 2022
@Remi749 @olemp @tarjeieo
v1.6.1 (#746)
af74d1b 
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

* 1.6.0

* Minor update to preInstallUpgrade script

* Hotfix: Add fallback for 'projectDeliveriesListName' in timeline

* Add ViewId for views in aggregated web parts (#745)

* Add ViewId for views in aggregated web parts

* Update changelog

* 1.6.1

* v1.6.1

* Update changelog

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemp olemp olemp approved these changes

@okms okms okms approved these changes

Assignees

@tarjeieo tarjeieo

Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Resource allocation displays 0% no matter the input
3 participants
@tarjeieo @okms @olemp