-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic and improved aggregated lists (Portfolio) #717
Conversation
Co-authored-by: Bloom <Remi749@users.noreply.github.com>
Co-authored-by: Bloom <Remi749@users.noreply.github.com>
Co-authored-by: Bloom <Remi749@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In god we trust
@@ -39,7 +39,7 @@ | |||
"object-assign": "4.1.1", | |||
"office-ui-fabric-react": "6.214.0", | |||
"pp365-projectwebparts": "latest", | |||
"pp365-shared": "latest", | |||
"pp365-shared": "1.5.4-706.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stemmer det at denne ikke lenger skal bruke latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Den skal bruke latest før master merge når vi upper versjonsnummer. Vi temp deployer versjoner av shared under utvikling med egen tag til npm (før versjonen økes ved merge).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PortfolioWebParts skal bruke latest ja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's get this into dev.
* Update PostInstallUpgrade script to remove unnecessary fields from * Update PreInstallUpgrade script to remove unnecessary fields from * Update Aggregated webparts with properties * Update PreInstallUpgrade script and remove overwrite true from pages * Fix problem where columns wasn't rendered properly * Update changelog
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703) * Timeline configuration, timeline rework + support for project deliveries (#698) * Timeline improvements * Update sp-js-provisioning for running hooks (#709) * Add improvements to document template selector (#712) * Fix for GtResourceLoad list column (#710) * Changed list fields to site fields in template * Handling upgrade of existing sites #610 * Added changelog * Order of events * Handling of incorrect field format * Transcripting upgrade * Minor formatting Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com> * More info for #705 * Dynamic and improved aggregated lists for Portfolio (#717) * Fix syntax for letter 'å' in template (Gevinstoversikt) (#721) * Minor fixes and imrovements to #717 (#722) * Update PostInstallUpgrade script to remove unnecessary fields from * Update PreInstallUpgrade script to remove unnecessary fields from * Update Aggregated webparts with properties * Update PreInstallUpgrade script and remove overwrite true from pages * Fix problem where columns wasn't rendered properly * Update changelog * if dataSourceCategory is missing for projects return null (#723) * Add handling of navigation, keep customer customizations and reapply * Add some extra checks for dataSourceCategory (Projectlevel) * Install/upgrade script improvements (#729) * Improved field descriptions of datasources fields (#728) * Field types not in sync with 'Prosjektinnholdskolonner' data (#732) * Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct * Add 'updateProjectContentColumn' when editing type/minWidth from webpart * Use minWidth value from 'Prosjektinnholdskolonner' list for columns * Initialize dataType for aggregated webpart columns correctly * 736 sync error (#737) * Fix for #736 * linting * Update packages * Further fixes after serving #736 * Changelog * lint fix * Minor changes Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com> * Update packages * Hopefully fixed #736 * Fix for #736 after more testing * Minor tweak after #736 * 1.6.0 Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com> Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703) * Timeline configuration, timeline rework + support for project deliveries (#698) * Timeline improvements * Update sp-js-provisioning for running hooks (#709) * Add improvements to document template selector (#712) * Fix for GtResourceLoad list column (#710) * Changed list fields to site fields in template * Handling upgrade of existing sites #610 * Added changelog * Order of events * Handling of incorrect field format * Transcripting upgrade * Minor formatting Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com> * More info for #705 * Dynamic and improved aggregated lists for Portfolio (#717) * Fix syntax for letter 'å' in template (Gevinstoversikt) (#721) * Minor fixes and imrovements to #717 (#722) * Update PostInstallUpgrade script to remove unnecessary fields from * Update PreInstallUpgrade script to remove unnecessary fields from * Update Aggregated webparts with properties * Update PreInstallUpgrade script and remove overwrite true from pages * Fix problem where columns wasn't rendered properly * Update changelog * if dataSourceCategory is missing for projects return null (#723) * Add handling of navigation, keep customer customizations and reapply * Add some extra checks for dataSourceCategory (Projectlevel) * Install/upgrade script improvements (#729) * Improved field descriptions of datasources fields (#728) * Field types not in sync with 'Prosjektinnholdskolonner' data (#732) * Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct * Add 'updateProjectContentColumn' when editing type/minWidth from webpart * Use minWidth value from 'Prosjektinnholdskolonner' list for columns * Initialize dataType for aggregated webpart columns correctly * 736 sync error (#737) * Fix for #736 * linting * Update packages * Further fixes after serving #736 * Changelog * lint fix * Minor changes Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com> * Update packages * Hopefully fixed #736 * Fix for #736 after more testing * Minor tweak after #736 * 1.6.0 * 1.6.0 Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com> Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703) * Timeline configuration, timeline rework + support for project deliveries (#698) * Timeline improvements * Update sp-js-provisioning for running hooks (#709) * Add improvements to document template selector (#712) * Fix for GtResourceLoad list column (#710) * Changed list fields to site fields in template * Handling upgrade of existing sites #610 * Added changelog * Order of events * Handling of incorrect field format * Transcripting upgrade * Minor formatting Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com> * More info for #705 * Dynamic and improved aggregated lists for Portfolio (#717) * Fix syntax for letter 'å' in template (Gevinstoversikt) (#721) * Minor fixes and imrovements to #717 (#722) * Update PostInstallUpgrade script to remove unnecessary fields from * Update PreInstallUpgrade script to remove unnecessary fields from * Update Aggregated webparts with properties * Update PreInstallUpgrade script and remove overwrite true from pages * Fix problem where columns wasn't rendered properly * Update changelog * if dataSourceCategory is missing for projects return null (#723) * Add handling of navigation, keep customer customizations and reapply * Add some extra checks for dataSourceCategory (Projectlevel) * Install/upgrade script improvements (#729) * Improved field descriptions of datasources fields (#728) * Field types not in sync with 'Prosjektinnholdskolonner' data (#732) * Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct * Add 'updateProjectContentColumn' when editing type/minWidth from webpart * Use minWidth value from 'Prosjektinnholdskolonner' list for columns * Initialize dataType for aggregated webpart columns correctly * 736 sync error (#737) * Fix for #736 * linting * Update packages * Further fixes after serving #736 * Changelog * lint fix * Minor changes Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com> * Update packages * Hopefully fixed #736 * Fix for #736 after more testing * Minor tweak after #736 * 1.6.0 * 1.6.0 * Minor update to preInstallUpgrade script * Hotfix: Add fallback for 'projectDeliveriesListName' in timeline * Add ViewId for views in aggregated web parts (#745) * Add ViewId for views in aggregated web parts * Update changelog * 1.6.1 * v1.6.1 * Update changelog Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com> Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Your checklist for this pull request
Description
A big change to the way the aggregated webparts at the Portfolio level works. Implementation of the same functionality found in the PortfolioOverview webpart. This includes Views, filtering, grouping, etc...
Aggregated webparts included in Prosjektportalen 365 that will be affected:
NOTE!
The improvements made here does not affect Program/Overordnet. The aggregated webparts that came with 'Program- and Overordnet-område' are created as unique webparts instead of using the Portfolio aggregated webpart directly and use the 'Datakilder' list to set up the source.
Because of this we will have to keep Program and Project at the pp365-portfoliowebpart@1.5.4-679.2 version until we have created new webparts for Program/Overordnet that will work directly and more seamlessly with the new additions made here.
Additions:
Provision template additions/changes:
New List (Title, Url added to resource files):
New SiteFields (Name, Descriptions added to resource files.)
Changes to Datakilder
Changes to datakilde contenttype
Changes to the following ClientSidePages
Changes
Aggregated webpart
Views
Filtering
Group by
Change in 'Datakilder' list (4 new columns)
Columns
Edit mode
How to test
Test out the changes made the aggregated webpart
a. Test odata query
Relevant issues (if applicable)
#706