Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic and improved aggregated lists (Portfolio) #717

Merged
merged 74 commits into from
Jun 13, 2022

Conversation

Remi749
Copy link
Collaborator

@Remi749 Remi749 commented Jun 7, 2022

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

A big change to the way the aggregated webparts at the Portfolio level works. Implementation of the same functionality found in the PortfolioOverview webpart. This includes Views, filtering, grouping, etc...

Aggregated webparts included in Prosjektportalen 365 that will be affected:

  • Gevinstoversikt
  • Erfaringslogg
  • Leveranseoversikt
  • Risikooversikt

NOTE!
The improvements made here does not affect Program/Overordnet. The aggregated webparts that came with 'Program- and Overordnet-område' are created as unique webparts instead of using the Portfolio aggregated webpart directly and use the 'Datakilder' list to set up the source.

Because of this we will have to keep Program and Project at the pp365-portfoliowebpart@1.5.4-679.2 version until we have created new webparts for Program/Overordnet that will work directly and more seamlessly with the new additions made here.

Additions:

  • Added button to 'Konfigurasjon av Prosjektportalen' page.
  • Added a new list.

Provision template additions/changes:

  • New List (Title, Url added to resource files):

    • Lists/Prosjektinnholdskolonner
  • New SiteFields (Name, Descriptions added to resource files.)

    • GtODataQuery (Note field to filter the projects found within the datasource searchquery)
    • GtProjectContentColumns (Lookup to 'Prosjektinnholdskolonner')
    • GtProjectContentGroupBy (Lookup to 'Prosjektinnholdskolonner')
    • GtProjectContentRefiners (Lookup to 'Prosjektinnholdskolonner')
  • Changes to Datakilder

    • Added the new SiteFields to the list
    • Reorder of columns in list
  • Changes to datakilde contenttype

    • Added the new SiteFields to the contenttype
  • Changes to the following ClientSidePages

    • Erfaringslogg, Leveranseoversikt, Risikooversikt, Gevinstoversikt
      • Removed all data for columns property in the webpart
      • Set Overwrite to true
    • Gevinstoversikt
      • Switched out the webpart to use aggregated webpart instead of the benefits webpart
    • Konfigurasjon
      • Added button (QuickLink) for 'Prosjektinnholdskolonner' list to 'Konfigurasjon av Prosjektportalen' page.

Changes

Aggregated webpart

  • Views

    • Ability to create new views
    • Possibility to see the views from 'Datakilder' in the drop-down menu with 'Edit' functionality.
      image
  • Filtering

    • Ability to filter the view based on the selected columns from 'Datakilder'
      image
  • Group by

    • Ability to set a pre-defined group by column based on the selected column from 'Datakilder'
  • Change in 'Datakilder' list (4 new columns)
    image

  • Columns

    • Columns defined in 'Datakilder' will be used instead of the columns found in webpart properties
    • Columns are editable same as before where all data is persisted
  • Edit mode

    • 'Legg til kolonne':
      • This will now show a dropdown instead of opening the Column panel (Legg til kolonne/Vis/skjul kolonner)
      • When creating a new column, the column is also created in the 'Prosjektinnholdskolonner' list and connected to the 'Datakilde' element for the current view
      • Deleting a column will also remove this from the 'prosjektinnholdskolonner' list
        • Columns: 'Prosjekt' and 'Tittel' can't be deleted.
      • Editing the name for the columns in an aggregated list will only persist the changes directly in the list and won't affect the element in the 'Prosjektinnholdskolonner' list
    • Added new option: 'Vis/skjul kolonner', ability to remove columns from Datakilder for the current view
      • Tried to replicate this to be identical to SharePoint out of the box version

How to test

Test out the changes made the aggregated webpart

  1. Check to see if 'Prosjektinnholdskolonner' and 'Datakilder' is correctly set up after upgrade
  2. Test creating, changing and editing views
  3. Test filtering
  4. Test group by
  5. Edit columns and test deleting custom columns
  6. Test 'vis/skjul kolonner'
  7. Make changes to 'Datakilder' list
    a. Test odata query

Relevant issues (if applicable)

#706

olemp and others added 30 commits May 10, 2022 12:20
Co-authored-by: Bloom <Remi749@users.noreply.github.com>
Co-authored-by: Bloom <Remi749@users.noreply.github.com>
Co-authored-by: Bloom <Remi749@users.noreply.github.com>
@Remi749 Remi749 added enhancement Request that will enhance the product priority: high Issue with high priority complexity: large Issue/PR with large complexity backend Related to backend/apis frontend Related to frontend customer funded Issues funded by customer labels Jun 7, 2022
@Remi749 Remi749 added this to the 1.6.0 milestone Jun 7, 2022
@Remi749
Copy link
Collaborator Author

Remi749 commented Jun 7, 2022

@olemp @tarjeieo, when do you think you have time to review or merge code?

Copy link
Member

@tarjeieo tarjeieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In god we trust

@@ -39,7 +39,7 @@
"object-assign": "4.1.1",
"office-ui-fabric-react": "6.214.0",
"pp365-projectwebparts": "latest",
"pp365-shared": "latest",
"pp365-shared": "1.5.4-706.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stemmer det at denne ikke lenger skal bruke latest?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den skal bruke latest før master merge når vi upper versjonsnummer. Vi temp deployer versjoner av shared under utvikling med egen tag til npm (før versjonen økes ved merge).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PortfolioWebParts skal bruke latest ja

@olemp
Copy link
Collaborator

olemp commented Jun 9, 2022

@olemp @tarjeieo, when do you think you have time to review or merge code?

I'll have a look on monday.

Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's get this into dev.

@olemp olemp merged commit cfb1c33 into dev Jun 13, 2022
@olemp olemp deleted the feature/dynamic-aggregated-lists branch June 13, 2022 12:04
@Remi749 Remi749 mentioned this pull request Jun 13, 2022
6 tasks
Remi749 added a commit that referenced this pull request Jun 13, 2022
* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog
Remi749 added a commit that referenced this pull request Jun 27, 2022
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Remi749 added a commit that referenced this pull request Jun 27, 2022
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

* 1.6.0

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Remi749 added a commit that referenced this pull request Jun 29, 2022
* In case of no default planner-elements, create a blank plan to avoid planner-webpart error on the front page (#703)

* Timeline configuration, timeline rework + support for project deliveries (#698)

* Timeline improvements

* Update sp-js-provisioning for running hooks (#709)

* Add improvements to document template selector (#712)

* Fix for GtResourceLoad list column (#710)

* Changed list fields to site fields in template

* Handling upgrade of existing sites #610

* Added changelog

* Order of events

* Handling of incorrect field format

* Transcripting upgrade

* Minor formatting

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* More info for #705

* Dynamic and improved aggregated lists for Portfolio (#717)

* Fix syntax for letter 'å' in template (Gevinstoversikt) (#721)

* Minor fixes and imrovements to #717  (#722)

* Update PostInstallUpgrade script to remove unnecessary fields from

* Update PreInstallUpgrade script to remove unnecessary fields from

* Update Aggregated webparts with properties

* Update PreInstallUpgrade script and remove overwrite true from pages

* Fix problem where columns wasn't rendered properly

* Update changelog

* if dataSourceCategory is missing for projects return null (#723)

* Add handling of navigation, keep customer customizations and reapply

* Add some extra checks for dataSourceCategory (Projectlevel)

* Install/upgrade script improvements (#729)

* Improved field descriptions of datasources fields (#728)

* Field types not in sync with 'Prosjektinnholdskolonner' data (#732)

* Add GtColMinWidth to 'Prosjektinnholdskolonner' list + ct

* Add 'updateProjectContentColumn' when editing type/minWidth from webpart

* Use minWidth value from 'Prosjektinnholdskolonner' list for columns

* Initialize dataType for aggregated webpart columns correctly

* 736 sync error (#737)

* Fix for #736

* linting

* Update packages

* Further fixes after serving #736

* Changelog

* lint fix

* Minor changes

Co-authored-by: Remi Blom-Ohlsen <remi.blom-ohlsen@puzzlepart.com>

* Update packages

* Hopefully fixed #736

* Fix for #736 after more testing

* Minor tweak after #736

* 1.6.0

* 1.6.0

* Minor update to preInstallUpgrade script

* Hotfix: Add fallback for 'projectDeliveriesListName' in timeline

* Add ViewId for views in aggregated web parts (#745)

* Add ViewId for views in aggregated web parts

* Update changelog

* 1.6.1

* v1.6.1

* Update changelog

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: Tarjei E. Ormestøyl <ormestoyl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend/apis complexity: large Issue/PR with large complexity customer funded Issues funded by customer enhancement Request that will enhance the product frontend Related to frontend priority: high Issue with high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants