Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with "typing to select" feature #715

Closed
ZhujinLi opened this issue Aug 7, 2020 · 5 comments
Closed

Conflict with "typing to select" feature #715

ZhujinLi opened this issue Aug 7, 2020 · 5 comments

Comments

@ZhujinLi
Copy link

ZhujinLi commented Aug 7, 2020

Describe the bug
Windows has a built-in feature that allows users to type into the Explorer view and select the corresponding file. But when doing so for a file whose name includes spaces, QuickLook would be invoked unexpectedly.

To Reproduce
Steps to reproduce the behavior:

  1. Open File Explorer and navigate to any directory
  2. Create two files "hello world.txt" and "hello wolf.txt"
  3. Type "hello wol" in order to select the second file
  4. QuickLook is invoked shortly after pressing 'space' key

Expected behavior
QuickLook is not invoked accidently during typing, unless that 'space' key combined with previous keystrokes doesn't match any existing file name. I assume this is technically viable.

Desktop (please complete the following information):

  • OS Version: Windows 10 Version 1909
  • QuickLook Version: 3.6.9 from Windows Store
@xupefei
Copy link
Member

xupefei commented Aug 7, 2020

This is a known issue that has no efficient solution. QL doesn't know if you are in typing-to-search mode :(

A possible solution is to record every keystroke and make sure a "good" space stoke is some milliseconds after any previous keystroke. But I'm afraid this strategy will consume quite a bit of CPU time.

@stefan5588
Copy link

First, many thanks for this utility, it is really useful!! Regarding the issue described above, I find myself using the "type-to-search" mode pretty often in long folder listings, which interferes with QuickLook. How about having an option to choose our own shortcut key to invoke QL, instead of having just the "space" key available? On my keyboard, which has a separate row of "F[unction]" keys, I could easily just press "F6" instead of "space"...

@xupefei xupefei reopened this Aug 23, 2020
@xupefei
Copy link
Member

xupefei commented Aug 23, 2020

I added one-second timeout before any previewing requests to solve this issue (afaik the same as macOS Quick Look).
Please try https://ci.appveyor.com/project/xupefei/quicklook/builds/34805404/artifacts and report if it solves your problem.

@ZhujinLi
Copy link
Author

I've tried the build and it works fine for me. The preview would not show as long as I'm typing, exactly like in macOS, which I haven't noticed before.
Much appreciated.

@ZhujinLi ZhujinLi reopened this Aug 23, 2020
@xupefei xupefei closed this as completed Aug 23, 2020
@stefan5588
Copy link

Works very well, thanks!

Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
@Jethro-Alter @Piteriuz
@xupefei @Bobcruise @davinhanif @rabelux
Merge from latest (#8)
d14fa5b 
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <piteriuz@outlook.com>
Co-authored-by: Pengfei Xu <xupaddy@gmail.com>
Co-authored-by: Bobcruise <bobcruise07@gmail.com>
Co-authored-by: davinhanif <39960696+davinhanif@users.noreply.github.com>
Co-authored-by: Alexander Raab <alexander.raab1@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xupefei @ZhujinLi @stefan5588