Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The portable version should not use %APPDATA% for storing configs #731

Closed
xupefei opened this issue Sep 14, 2020 · 1 comment
Closed

The portable version should not use %APPDATA% for storing configs #731

xupefei opened this issue Sep 14, 2020 · 1 comment
Assignees

Comments

@xupefei
Copy link
Member

xupefei commented Sep 14, 2020

For all's convenience, please use English to fill this issue.

Please search within existing issues before the submission. Has this issue already been reported?

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
N/A

Expected behavior
See the title.

Desktop (please complete the following information):

  • OS Version: All versions
  • QuickLook Version: All portable versions

Screenshots and Exception Log
If applicable, add screenshots and logs to help explain your problem. The log file is located in %APPDATA%\pooi.moe\QuickLook\QuickLook.Exception.log (.msi or .zip version) or %LOCALAPPDATA%\Packages\21090PaddyXu.QuickLook_egxr34yet59cg\LocalCache\Roaming\pooi.moe\QuickLook\QuickLook.Exception.log (Windows Store version).

@xupefei xupefei self-assigned this Sep 14, 2020
@just-Addict
Copy link

just-Addict commented Sep 19, 2020

I know you're the developer but breaking your own request?
The template isn't there for just show ;)

So let me expand this a little since just referring to the title is meh...

Describe the bug
When running the so-called portable version. The Config file and any user installed plugins end up in
%APPDATA%\pooi.moe\QuickLook\ (config)
%APPDATA%\pooi.moe\QuickLook\QuickLook.Plugin (plugins)

To Reproduce
unpack portable version after unblocking (and not unlocking)
run it and install some additional plugins.
Explore the above mentioned locations.
Find files there

Expected behavior
The concept of being portable means that any and ALL configuration files and additional files should be stored in the application's own folder or sub folders thereof. Using %APPDATA% does not only make the application not portable. It will partly cease to function as expected when actually used as a portable application on a USB medium and taken to another PC, because user installed plugins do not get included.

Desktop (please complete the following information):

OS Version: All versions
QuickLook Version: All portable versions
Screenshots and Exception Log
If applicable, add screenshots and logs to help explain your problem.

Not Applicable

Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <piteriuz@outlook.com>
Co-authored-by: Pengfei Xu <xupaddy@gmail.com>
Co-authored-by: Bobcruise <bobcruise07@gmail.com>
Co-authored-by: davinhanif <39960696+davinhanif@users.noreply.github.com>
Co-authored-by: Alexander Raab <alexander.raab1@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants