Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue previewing vertical RAW images #759

Closed
AndrewSRiddle opened this issue Oct 14, 2020 · 9 comments
Closed

Issue previewing vertical RAW images #759

AndrewSRiddle opened this issue Oct 14, 2020 · 9 comments

Comments

@AndrewSRiddle
Copy link

Describe the bug
The quick preview works great for horizontal images, comes up immediately. But when the RAW image is vertical quick preview squishes the image and changes it's rotation for about 5-8 seconds and then previews it normal after that. Might not seem like a huge problem but when you're sorting and upwards of 4-5k RAW images that 5-8 seconds is a lot.

Expected behavior
I expect an immediate clear preview like it already does for horizontal images.

Desktop (please complete the following information):

  • OS Version: [Windows 10 Pro]
  • QuickLook Version: [3.6.10.0]

Screenshots and Exception Log
Quicklook vertical RAW preivew Issues
@xupefei
Copy link
Member

xupefei commented Oct 14, 2020

I thought the thumbnail in ARW should be in the right orientation so didn't rotate it.

Could you share me a vertical ARW file? I'll look into this issue this weekend.

@AndrewSRiddle
Copy link
Author

I thought the thumbnail in ARW should be in the right orientation so didn't rotate it.

Could you share me a vertical ARW file? I'll look into this issue this weekend.

Please be more clear. I do not understand what you want.

@xupefei
Copy link
Member

xupefei commented Oct 14, 2020

I thought the thumbnail in ARW should be in the right orientation so didn't rotate it.
Could you share me a vertical ARW file? I'll look into this issue this weekend.

Please be more clear. I do not understand what you want.

Sorry about that. What I want is a vertical RAW file (for example the one in your screenshot) to debug and fix this issue.

@AndrewSRiddle AndrewSRiddle reopened this Oct 14, 2020
@AndrewSRiddle
Copy link
Author

Doesn't look like it'll let me attach RAW files. Here's a Dropbox link. It displays perfectly in Dropbox.

https://www.dropbox.com/sh/pks5ixgchn02lxc/AABk19X0zm6zDF5TzQOGJ7Hja?dl=0

@AndrewSRiddle AndrewSRiddle reopened this Oct 14, 2020
@xupefei
Copy link
Member

xupefei commented Oct 17, 2020

Can you try this version https://ci.appveyor.com/project/xupefei/quicklook/builds/35806705/artifacts to see if your issue is fixed?

@AndrewSRiddle
Copy link
Author

I'm confused by what i'm supposed to do with that.

@AndrewSRiddle
Copy link
Author

IT WORKED! It was that first file. I uninstalled quicklook and downloaded that first file and it worked! Thank you! What was the issue?

@AndrewSRiddle
Copy link
Author

You have no idea how thankful I am. You're amazing.

@xupefei
Copy link
Member

xupefei commented Oct 17, 2020

You are welcome.

What was the issue?

No issue now. I see it is resolved for you :)

Jethro-Alter added a commit to Jethro-Alter/QuickLook that referenced this issue Dec 21, 2020
@Jethro-Alter @Piteriuz
@xupefei @Bobcruise @davinhanif @rabelux
Merge from latest (#8)
d14fa5b 
* Update Translations.config

* Update Translations.config

* Update Translations.config

* Create Privacy.md

* Rename Privacy.md to PRIVACY.md

* Update PRIVACY.md

* Update PRIVACY.md

* Fix QL-Win#579: search box changed in Windows 10 1909

* Fix QL-Win#579: also deal with non-English UIs

* don't bring existing window to the front

* Revert "Fix QL-Win#644: still use focusable window on Windows 7 and 8"

This reverts commit 452574e.

Revert "Fix QL-Win#644 step 1: correctly bring window back to top when clicked"

This reverts commit af608dc.

* Fix QL-Win#401: use the native image provider to render static GIFs

* Update Translations.config

Hungarian language added.

* Fix QL-Win#669: convert image to sRGB only when the original ColorSpace is RGB, sRGB, or scRGB

* Upgrade Magick.NET packages

* Fix QL-Win#669 again: stupid syntax mistake :(

* Bulk update NuGet packages

* Update Translations.config

Typo correction on line 61 and 69. Fixing slight translation mistakes and some words also replaced with more commonly used words.

* Support File Path longer than 260 (tweak needed: https://www.tenforums.com/tutorials/51704-enable-disable-win32-long-paths-windows-10-a.html)

* Add EXR to ImageViewer

* Add MXF to VideoViewer

* Decrease update checking frequency to monthly

* Fix QL-Win#715: add 1s timeout before any previewing request

* Fix QL-Win#711: adjust UI before loading any PDF page

* Fix QL-Win#729: add a config flag to hide the tray icon

* Fix QL-Win#731: use app folder for saving data in the portable mode

* Fix QL-Win#733: detect Markdown encoding

* Fix QL-Win#734: add AVIF format

* Update .appveyor.yml

* added german translation for newly added string

* fix a typo

* Fix QL-Win#744: Components are not correctly disposed upon exit

* Fix QL-Win#477: Add JFIF files

* Update bug_report.md

* typo

* Fix QL-Win#420, QL-Win#452, QL-Win#757: windows positioning for monitors with different DPIs

* Update Common to fix plugin resize

* Fix QL-Win#759: fix thumbnail orientation for some camera models

* Fix QL-Win#760, support CR3

* removed dup of ".asf" and added ".mka" for testing

Co-authored-by: Piteriuz <piteriuz@outlook.com>
Co-authored-by: Pengfei Xu <xupaddy@gmail.com>
Co-authored-by: Bobcruise <bobcruise07@gmail.com>
Co-authored-by: davinhanif <39960696+davinhanif@users.noreply.github.com>
Co-authored-by: Alexander Raab <alexander.raab1@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xupefei @AndrewSRiddle