Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for backends with defective qubits and gates #4110

Merged
merged 73 commits into from
Jul 13, 2020
Merged

Support for backends with defective qubits and gates #4110

merged 73 commits into from
Jul 13, 2020

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Apr 8, 2020 •
edited
Loading

Like #4083 but assuming the functional coupling map is connected. This approach is simpler, so the only pending here deceside a coupling map when is disconnected. (feature added in 232e1b8)

Example:
Consider the following coupling map, were Q1 is non-operational:

         0 ↔ (1) ↔ 3 ↔ 4
              ↕
              2

The functional coupling map in this situation is only 3 ↔ 4.

circuit = QuantumCircuit(QuantumRegister(2, 'qr'))
circuit.h(range(2))
circuit.cz(0, 1)
circuit.measure_all()
result = transpile(circuit, backend=FakeOurenseFaultyQ1())
print(result)
disconnected_0 -> 0 ──────────────────────────────────────

      faulty_0 -> 1 ──────────────────────────────────────

disconnected_1 -> 2 ──────────────────────────────────────
                    ┌──────────┐                  ░ ┌─┐
          qr_0 -> 3 ┤ U2(0,pi) ├──■───────────────░─┤M├───
                    └──────────┘┌─┴─┐┌──────────┐ ░ └╥┘┌─┐
          qr_1 -> 4 ────────────┤ X ├┤ U2(0,pi) ├─░──╫─┤M├
                                └───┘└──────────┘ ░  ║ └╥┘
            meas_0: ═════════════════════════════════╩══╬═
                                                        ║
            meas_1: ════════════════════════════════════╩═

Luciano Bello added 30 commits March 27, 2020 12:37
initial commit
e4035a6
Merge branch 'master' of github.com:Qiskit/qiskit-terra into defectiv…
f14f154 
…e_qubits_and_gates
faulty qubit insertion
1b4b5f5
operational False
102cb57
pruned coupling map
ad0261a
no gate operation parameter for now
b13e6fb
faulty gate
0accd6d
fake_ourense_faulty_cx13
c7422d1
testing of the fake backends
5d8fa92
Merge branch 'master' of github.com:Qiskit/qiskit-terra into defectiv…
f9f2cc4 
…e_qubits_and_gates
Merge branch 'master' of github.com:Qiskit/qiskit-terra into defectiv…
d8ea453 
…e_qubits_and_gates
a test
1c5c683
disconnected coupling map
a9b5fce
add fault register at the end
2b5d3b0
transform the circuit into the faulty backend
702adc9
simulators do not have properties
6103f0a
assertIdleQ1
250bc42
assertEqualCount
644196b
remove faulty qubtis from properties
26cd85d
backend_property for faulty qubits
4c37fea
adapt Layout2qDistance to disconnected coupling map
d906cdd
Merge branch 'master' of github.com:Qiskit/qiskit-terra into defectiv…
444a435 
…e_qubits_and_gates
remove _create_qreg
a38c101
assuming coupling map
108c7cd
layout with disconnected qubits
a38a923
test for faulty gate
92f5f94
support for faulty gate
775aa5e
remove gates when they are faulty from the backend properties
c83e48b
test
7fd8f3f
unused import
86cf9b6
ajavadia
ajavadia reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except location of two methods

qiskit/providers/basebackend.py Outdated
@@ -62,6 +62,30 @@ def configuration(self):
"""
return self._configuration

def faulty_qubits(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be a method of base backend. it should be in qiskit/providers/models/backendproperties.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved in db52ca4

qiskit/providers/basebackend.py Outdated
faulty.append(qubit)
return faulty

def faulty_gates(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved in db52ca4

mergify bot and others added 10 commits July 7, 2020 15:30
@mergify mergify bot merged commit 41cf87c into Qiskit:master Jul 13, 2020
mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Jul 16, 2020
@mtreinish
Revert "Support for backends with defective qubits and gates (Qiskit#…
68b10ee 
…4110)"

This commit reverts Qiskit#4110 which has introduced several issues with
transpilation in parallel. It's causing hangs for characterization
circuit transpilation in ignis which is breaking ignis CI. It also
straight up breaks parallel transpilation with the ibmq provider,
see Qiskit/qiskit-ibmq-provider#712. The fundamental cause seems to be
that Qiskit#4110 added new arguments to the parallel_map call inside transpile
which uses types which are not guaranteed to pickleable or hang while
trying to pickle them. This breaks transpile >1 input circuit with these
backends. This wasn't caught in tests because we don't directly test
these backends because they're outside of terra.

This reverts commit 41cf87c.
This was referenced Jul 16, 2020
Merged
Closed
kdk pushed a commit that referenced this pull request Jul 16, 2020
@mtreinish
Revert "Support for backends with defective qubits and gates (#4110)" (…
aa96d9e 
…#4723)

This commit reverts #4110 which has introduced several issues with
transpilation in parallel. It's causing hangs for characterization
circuit transpilation in ignis which is breaking ignis CI. It also
straight up breaks parallel transpilation with the ibmq provider,
see Qiskit/qiskit-ibmq-provider#712. The fundamental cause seems to be
that #4110 added new arguments to the parallel_map call inside transpile
which uses types which are not guaranteed to pickleable or hang while
trying to pickle them. This breaks transpile >1 input circuit with these
backends. This wasn't caught in tests because we don't directly test
these backends because they're outside of terra.

This reverts commit 41cf87c.
This was referenced Jul 16, 2020
Closed
Merged
@1ucian0 1ucian0 mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajavadia ajavadia ajavadia approved these changes

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

@ewinston ewinston Awaiting requested review from ewinston

@itoko itoko Awaiting requested review from itoko

@jyu00 jyu00 Awaiting requested review from jyu00

@kdk kdk Awaiting requested review from kdk

@lcapelluto lcapelluto Awaiting requested review from lcapelluto

@mtreinish mtreinish Awaiting requested review from mtreinish

@taalexander taalexander Awaiting requested review from taalexander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@1ucian0 @ajavadia