refactor: Simplify CLI starters #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
gioboa
requested changes
Jul 2, 2024
Ah yes, was going to tackle this. I still need to test the CLI and get more familiar with it. So converting to draft for now. |
|
commit: @builder.io/qwik
@builder.io/qwik-city
eslint-plugin-qwik
create-qwik
|
|
Ok it's ready for review. I've changed the validate cli command to account for the current starters, pkg pr new with the latest cli artifact for the three different templates. For pkg pr new I tested consuming them with and without dependencies, as well as the dev mode of each. Happy to make any adjustments if needed 👍 |
dario-piotrowicz
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Sep 18, 2024
…dflare/src/frameworks` As part of this update the 'basic' template to its new name 'playground' (renamed in QwikDev/qwik#6632)
edmundhung
pushed a commit
to cloudflare/workers-sdk
that referenced
this pull request
Sep 19, 2024
* fix: add missing `nodejs_compat` flag to c3 qwik template The c3 qwik template doesn't include the `nodejs_compat` but qwik seems to be using AsyncLocalStorage, so newly created applications do display a warning regarding it missing, fix the above issue by adding the missing compat flag * chore: bump create-qwik from 1.5.7 to 1.9.0 in `/packages/create-cloudflare/src/frameworks` As part of this update the 'basic' template to its new name 'playground' (renamed in QwikDev/qwik#6632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Checklist: