Skip to content

Commit

Permalink
C3: bump qwik to 1.9.0 (#6755)
Browse files Browse the repository at this point in the history
* fix: add missing `nodejs_compat` flag to c3 qwik template

The c3 qwik template doesn't include the `nodejs_compat` but qwik seems to be using
AsyncLocalStorage, so newly created applications do display a warning regarding it
missing, fix the above issue by adding the missing compat flag

* chore: bump create-qwik from 1.5.7 to 1.9.0 in `/packages/create-cloudflare/src/frameworks`

As part of this update the 'basic' template to its new name 'playground'
(renamed in QwikDev/qwik#6632)
  • Loading branch information
dario-piotrowicz authored Sep 19, 2024
1 parent 2ddbb65 commit a602de0
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 3 deletions.
9 changes: 9 additions & 0 deletions .changeset/few-feet-appear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"create-cloudflare": patch
---

fix: add missing `nodejs_compat` flag to c3 qwik template

The c3 qwik template doesn't include the `nodejs_compat` but qwik seems to be using
AsyncLocalStorage, so newly created applications do display a warning regarding it
missing, fix the above issue by adding the missing compat flag
11 changes: 11 additions & 0 deletions .changeset/spotty-snails-design.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"create-cloudflare": patch
---

- chore: update dependencies of "create-cloudflare" package

The following dependency versions have been updated:

| Dependency | From | To |
| ----------- | ----- | ----- |
| create-qwik | 1.5.7 | 1.9.0 |
2 changes: 1 addition & 1 deletion packages/create-cloudflare/src/frameworks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"create-docusaurus": "3.5.2",
"create-hono": "0.12.0",
"create-next-app": "14.2.5",
"create-qwik": "1.5.7",
"create-qwik": "1.9.0",
"create-vite": "5.2.3",
"create-remix": "2.11.1",
"create-solid": "0.5.12",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type { C3Context } from "types";
const { npm, npx } = detectPackageManager();

const generate = async (ctx: C3Context) => {
await runFrameworkGenerator(ctx, ["basic", ctx.project.name]);
await runFrameworkGenerator(ctx, ["playground", ctx.project.name]);
};

const configure = async (ctx: C3Context) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/create-cloudflare/templates/qwik/c3.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type { C3Context } from "types";
const { npm, npx } = detectPackageManager();

const generate = async (ctx: C3Context) => {
await runFrameworkGenerator(ctx, ["basic", ctx.project.name]);
await runFrameworkGenerator(ctx, ["playground", ctx.project.name]);
};

const configure = async (ctx: C3Context) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
name = "<TBD>"
compatibility_date = "<TBD>"
pages_build_output_dir = "./dist"
compatibility_flags = ["nodejs_compat"]

# Automatically place your workloads in an optimal location to minimize latency.
# If you are running back-end logic in a Pages Function, running it closer to your back-end infrastructure
Expand Down

0 comments on commit a602de0

Please sign in to comment.