Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: bump qwik to 1.9.0 #6755

Merged
merged 2 commits into from
Sep 19, 2024
Merged

C3: bump qwik to 1.9.0 #6755

merged 2 commits into from
Sep 19, 2024

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Sep 18, 2024

What this PR solves / how to test

This PR bumps the create-qwik version to 1.9.0

It also adds the missing nodejs_compat flag needed by the qwik starter template

Fixes N/A

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: the tests are already present
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not user facing changes

The c3 qwik template doesn't include the `nodejs_compat` but qwik seems to be using
AsyncLocalStorage, so newly created applications do display a warning regarding it
missing, fix the above issue by adding the missing compat flag
…dflare/src/frameworks`

As part of this update the 'basic' template to its new name 'playground'
(renamed in QwikDev/qwik#6632)
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 37bd115

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-wrangler-6755

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6755/npm-package-wrangler-6755

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-wrangler-6755 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-create-cloudflare-6755 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-cloudflare-kv-asset-handler-6755
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-miniflare-6755
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-cloudflare-pages-shared-6755
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-cloudflare-vitest-pool-workers-6755
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-cloudflare-workers-editor-shared-6755
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10930351702/npm-package-cloudflare-workers-shared-6755

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.5 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.3
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz added the e2e Run e2e tests on a PR label Sep 18, 2024
@edmundhung edmundhung merged commit a602de0 into main Sep 19, 2024
35 of 37 checks passed
@edmundhung edmundhung deleted the c3-bump-qwik branch September 19, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants