Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwerveModule class doesn't set Duty Cycle encoder as the feedback device #7

Closed
r4stered opened this issue Jan 23, 2023 · 0 comments · Fixed by #8
Closed

SwerveModule class doesn't set Duty Cycle encoder as the feedback device #7

r4stered opened this issue Jan 23, 2023 · 0 comments · Fixed by #8

Comments

@r4stered
Copy link
Contributor

https://www.chiefdelphi.com/t/sparkmax-c-pid-controller-with-maxswerve-not-functioning-as-expected/424387/2
@r4stered r4stered mentioned this issue Jan 23, 2023
Merged
jfabellera added a commit that referenced this issue Jan 23, 2023
@r4stered @jfabellera
Fixes C++ example not using the correct encoder (#8)
b16ba87 
* Fixes C++ example not using the correct encoder

Fixes #7

* Fix comment

Co-authored-by: Jan-Felix Abellera <jfabellera@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes C++ example not using the correct encoder
1 participant
@r4stered