Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes C++ example not using the correct encoder #8

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Fixes C++ example not using the correct encoder #8

merged 2 commits into from
Jan 23, 2023

Conversation

r4stered
Copy link
Contributor

Fixes #7

jfabellera
jfabellera requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@jfabellera jfabellera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, just some small things in the comment before merging

src/main/cpp/subsystems/MAXSwerveModule.cpp Outdated Show resolved Hide resolved
@jfabellera jfabellera merged commit b16ba87 into REVrobotics:main Jan 23, 2023
@r4stered r4stered deleted the patch-1 branch January 23, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfabellera jfabellera jfabellera requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwerveModule class doesn't set Duty Cycle encoder as the feedback device
2 participants
@r4stered @jfabellera