Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C samples #34

Closed
wants to merge 7 commits into from
Closed

C samples #34

wants to merge 7 commits into from

Conversation

hansely
Copy link
Contributor

@hansely hansely commented Jan 29, 2019

No description provided.

@kiritigowda kiritigowda self-requested a review January 30, 2019 18:04
@kiritigowda kiritigowda added the enhancement New feature or request label Jan 30, 2019
kiritigowda
kiritigowda reviewed Jan 30, 2019
View reviewed changes
Copy link
Collaborator

@kiritigowda kiritigowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will not build on windows, as vx_nn is not supported in windows.

samples/C Samples/Canny/CMakeLists.txt Outdated
include_directories (/opt/rocm/mivisionx/include)
link_directories (/opt/rocm/mivisionx/lib)
add_executable(cannyDetect canny.cpp)
target_link_libraries(${PROJECT_NAME} openvx vx_nn ${OpenCV_LIBRARIES})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vx_nn not required

samples/C Samples/OpenCV_orb/CMakeLists.txt Outdated
include_directories (/opt/rocm/mivisionx/include)
link_directories (/opt/rocm/mivisionx/lib)
add_executable(orbDetect orb.cpp)
target_link_libraries(${PROJECT_NAME} openvx vx_nn vx_opencv ${OpenCV_LIBRARIES})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vx_nn not required

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansely please make the changes for this to be merged.

amd_openvx_extensions/amd_opencv/include/vx_ext_opencv.h
@@ -22,7 +22,6 @@ THE SOFTWARE.


#include "VX/vx.h"
#include "vx_opencv.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged in pr #33

samples/C Samples/OpenCV_orb/orb.cpp Outdated

vx_int32 nFeatures = 1000;
vx_float32 scaleFactor = 1.2;
vx_int32 nlevels = 8;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nlevels set to 2

kiritigowda
kiritigowda reviewed Feb 1, 2019
View reviewed changes
Copy link
Collaborator

@kiritigowda kiritigowda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansely Everything looks good, please change the folder name to c_samples to be merged.

@hansely hansely closed this Feb 4, 2019
kiritigowda added a commit that referenced this pull request Mar 15, 2021
@kiritigowda @LakshmiKumar23
@hansely123 @hansely @paveltc
OpenVX 1.3 Support (#372)
4aeb30f 
* OpenVX 1.3 Headers Added

* Temp Changes to build MIVisionX with OpenVX 1.3 Headers

* VX NN 1.3 Port

* Lk/openvx port 1.3 (#2)

* changes for object-array

* threshold functions & adding objectarray to ago_util

* remap functions

* advanced array functions

* vxCreateMatrixFromPatternAndOrigin

* setImagePixelValues

* OpenVX 1.3 Conformance build

* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* latest changes (#5)

* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* fixes vxGetUserStructNameByEnm and EnumByName

* fixes vxCreateObjectArray and vxCreateVirtualObjectArray

* conformance test nodes

* bug ifx

* declaration added

* threshold functions

* fixes matrix functions

* fixes vxSetImagePixelValues

* fixes remap functions

* threshold typo fix

* changed all of objectarray to replicate delay

* threshold kernels

* weighted average invalid format fix

* fixes vxCreateVirtualScalar

* fixes vxCReateVirtualConvolution

* fixes vxCopyLUT & vxMapLUT

* fixing

* weightedaverage passed

* fix comment

* graph/context/refernce+ fixes

* target base passes all - vx_context

* waitGraph and verifyGraphBase

* undo verifyGraphBase

* nonlinearfilter passing

* latest chanegs

* Update CMakeLists.txt

* Update ago_platform.h

* Update vx_api.cpp

* moving #def from VX/include to vx_ext_amd.h

* moving #def from VX/include to vx_ext_amd.h

* adjusting spaces

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* Lk/port1.3 fix new (#6)

* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* fixes vxGetUserStructNameByEnm and EnumByName

* fixes vxCreateObjectArray and vxCreateVirtualObjectArray

* conformance test nodes

* bug ifx

* declaration added

* threshold functions

* fixes matrix functions

* fixes vxSetImagePixelValues

* fixes remap functions

* threshold typo fix

* changed all of objectarray to replicate delay

* threshold kernels

* weighted average invalid format fix

* fixes vxCreateVirtualScalar

* fixes vxCReateVirtualConvolution

* fixes vxCopyLUT & vxMapLUT

* fixing

* weightedaverage passed

* fix comment

* graph/context/refernce+ fixes

* target base passes all - vx_context

* waitGraph and verifyGraphBase

* undo verifyGraphBase

* nonlinearfilter passing

* latest chanegs

* Update CMakeLists.txt

* Update ago_platform.h

* Update vx_api.cpp

* moving #def from VX/include to vx_ext_amd.h

* moving #def from VX/include to vx_ext_amd.h

* adjusting spaces

* moving things from openvx/include to ext_amd

* laplacian update

* disable opencl

* Update CMakeLists.txt

* Update ago_interface.cpp

* Update vx_api.cpp

* LaplacianReconstruct pass

* bug fix

* bracket fix

* remove debug comments

* Update ago_haf_cpu_generic_functions.cpp

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* changes from Hansel and threshold changes (#7)

* remove debug comments

* Update ago_haf_cpu_generic_functions.cpp

* changes to threshold

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* OpenVX 1.3 port - Laplacian Pyramid (#8)

* Laplacian pyramid fix (#9)

* LaplacianPyramid Pass

* CMake fix

* Revert change

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* OpenVX Port - fix build failures (#10)

* Revert change

* opencl changes to threshold

* threshold with C code

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* mean std deviation fix  (#11)

* fixes meanstddev

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* user node 20/74 tests passes  (#12)

* usernode 20 out of 74 tests pass

* removing printf statements

* spacing fix

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* USerNode: All tests pass (#13)

* spacing fix

* adding verification path to fix user node

* fixes all tests of the user node

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* SwapImageHandle roi=false cases passes (#14)

* fixes all tests of userNode

* swapImageHandle - roi=false cases

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* Fixes ReplicateNode-ObjectArray (#17)

* swapImageHandle - roi=false cases

* fixes replicateNode object array

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* fixes LUT type=S16 failures (#18)


* fixes LUT failures

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* H/openvx 1.3 port new (#19)

* wait graph fixed

* deadlock debug

* deadlock fixed

* cmake fix

* comments added

Co-authored-by: LakshmiKumar23 <kumar.lakshmi1994@gmail.com>

* OpenVX 1.3 Fix

* weighted average validation fix

* graphstate fixed

* check fix

* bug fix

* SmokeTestBase.vxReleaseReferenceBase fix (#21)

* SmokeTestBase.vxReleaseReferenceBase fix

* SmokeTestBase.vxSetReferenceName fix

* Graph State - Fix & code cleanup (#22)

* Graph Tests - Fix (#23)

* code cleanup

* user node fixes

* graph state fixes

* smoketestbase - vxRetainReferenceBase fix (#24)

* smoketestbase-vxRetainReferenceBase fix

* histogram - Fix CTS Errors(#25)

* debugging histogram

* histogram fix

* code cleanup

* Resource Release Fix

* OpenVX 1.3 - half scale gaussian (#27)

* halfscalegaussian fix

* code cleanup

* OpenVX 1.3 - smokeTest.vxRetainReference & smokeTestBase.vxSetReferenceName fix (#26)

* vxRetainRef line 371  fix

* vxSetReferenceName fix

* pyramid fixes

* smoke test fixes for dangling references

* resolves all dangling reference issues

* vxUnloadKernels Fix (#28)

* CTS - graph delay with pyramid fix (#29)

* Canny - CTS bug fix (#30)

* divide by 4 when grad size 7

* canny fix

* merge

* canny fix

* code cleanup

* Run OpenVX 1.3 CPU Conformance

* Travis Fix - OpenVX 1.3

* Travis Cleanup

* OpenVX 1.3 - Harris corner CTS Fix (#31)

* CMake

* harris fix

* code cleanup

* swapImageHandle  (#32)

* changing buffers to reflect right values

* getting correct pointers for ROI

* buffer values for multiple plane images

* fixes 12/39 swapImageHandle cases

* fixes all swapImageHandle errors

* fixes color convert  errors (#33)

* fixes conversion from RGBX to NV12&IYUV

* fixes conversion from UYVY to NV12&IYUV

* fixes conversion from YUYV to NV12&IYUV

* fixes converion from NV12,NV21&IYUV to RGBX

* fixes conversion from NV12,NV21&IYUV to RGB

* warp affine - fix (#34)

* warp affine fix

* code cleanup

* Travis - Trace Error

* Travis - Check VGA

* Travis Updates

* Fix - variable scope

* CXX Flags & OpenVX Version Update

* changed Threshold to support new OpenVX 1.3 format (#38)

Co-authored-by: paveltc <pavel.tcherniaev@amd.com>

* Threshold - Update to 1.3

* Jenkins - Check Build & Artifacts

* Tests - Fix platform name

* GPU Fix - multiply gpu (#39)

* CMake

* multiply fix

* code cleanup

* GPU Flow - Canny Fix (#36)

* CMake

* canny fix

* code cleanup

* GPU Flow - Bug Fixes (#35)

* fixes GraphROI.Simple & vxMapRemapPatch.MapRandomRemap

* Graph.GraphState

* fixes Threshold.OnRandom/4/Graph/BINARY/U8/U8

* removing unwanted commits

* fixes Threshold.OnRandom/5/Graph/BINARY/S16/U8

* fixes Threshold.OnRandom/7/Graph/RANGE/S16/U8

* removing unnecessary changes

* GPU Flow - fixes LUT for data type s16 (#40)

* GPU Flow - channel combine (#41)

* channel combine fix

* merge fix

Co-authored-by: LakshmiKumar23 <kumar.lakshmi1994@gmail.com>
Co-authored-by: Hansel Yang <hanselyang123@gmail.com>
Co-authored-by: Kiriti Gowda <kiriti@Kiritis-MacBook-Pro.local>
Co-authored-by: LakshmiKumar23 <lakshmi.kumar@amd.com>
Co-authored-by: Hansel Yang <hansyang@amd.com>
Co-authored-by: Kiriti Nagesh Gowda <kiritigowda@Kiritis-MacBook-Pro.local>
Co-authored-by: Pavel Tcherniaev <ptcherni@amd.com>
Co-authored-by: paveltc <pavel.tcherniaev@amd.com>
@rrawther rrawther mentioned this pull request Jun 14, 2021
Closed
swetha097 referenced this pull request in swetha097/MIVisionX Aug 28, 2023
@SundarRajan28
rocAL - Pybind changes for tensor augmentations (#34)
1a8d829 
* Adding pybind changes to tensor pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiritigowda kiritigowda kiritigowda left review comments

Assignees

@hansely hansely

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansely @kiritigowda @hansely123