Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIVisionX Setup Script Fix #6

Merged
merged 2 commits into from
Jan 3, 2019
Merged

MIVisionX Setup Script Fix #6

merged 2 commits into from
Jan 3, 2019

Conversation

kiritigowda
Copy link
Collaborator

  • sudo requirement removed
  • fixed bugs

This was referenced Jan 3, 2019
Closed
Closed
@jlgreathouse
Copy link

LGTM for the the issues it's aiming to fix, thanks!

What are your thoughts of putting #! /usr/bin/env python on the first line and chmod +x the script so that it could be run directly (./MIVisionX-setup.py) instead of having to call python MIVisionX-setup.py?

@kiritigowda
Copy link
Collaborator Author

LGTM for the the issues it's aiming to fix, thanks!

What are your thoughts of putting #! /usr/bin/env python on the first line and chmod +x the script so that it could be run directly (./MIVisionX-setup.py) instead of having to call python MIVisionX-setup.py?

@jlgreathouse Thanks for reporting these issues. I will merge this to the master. Please do report any problems or bugs you encounter.

Any particular reason for having ./MIVisionX-setup.py instead of the python MIVisionX-setup.py?

@kiritigowda kiritigowda added the bugfix Bug fixes to existing features label Jan 3, 2019
@kiritigowda kiritigowda merged commit 2c92f15 into ROCm:master Jan 3, 2019
@jlgreathouse
Copy link

@kiritigowda on Linux anyway, it's usually common practice for scripts to be executable directly. It's the whole reason for the hashbang mechanism is to treat scripts as executables so you don't need to personally know what interpreter is being used.

@kiritigowda
Copy link
Collaborator Author

@jlgreathouse thanks for the information, I will make those changes in my next commit.

@kiritigowda kiritigowda removed the request for review from paveltc January 4, 2019 00:32
@kiritigowda kiritigowda deleted the kg/master branch January 4, 2019 00:33
hansely referenced this pull request in hansely/MIVisionX May 2, 2019
@hansely123 @japarada
H/graph ui polish (#6)
7db60ff 
* nnir_to_openvx print (ROCm#103)

* Ubuntu 18.04 warnings fix (ROCm#104)

* Support for ONNX V1.3 (ROCm#101)

ONNX 1.3 support for ResNet50

* graph ui polished
hansely referenced this pull request in hansely/MIVisionX Apr 7, 2020
@LakshmiKumar23 @hansely123
Lk/port1.3 fix new (#6)
a68c081 
* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* fixes vxGetUserStructNameByEnm and EnumByName

* fixes vxCreateObjectArray and vxCreateVirtualObjectArray

* conformance test nodes

* bug ifx

* declaration added

* threshold functions

* fixes matrix functions

* fixes vxSetImagePixelValues

* fixes remap functions

* threshold typo fix

* changed all of objectarray to replicate delay

* threshold kernels

* weighted average invalid format fix

* fixes vxCreateVirtualScalar

* fixes vxCReateVirtualConvolution

* fixes vxCopyLUT & vxMapLUT

* fixing

* weightedaverage passed

* fix comment

* graph/context/refernce+ fixes

* target base passes all - vx_context

* waitGraph and verifyGraphBase

* undo verifyGraphBase

* nonlinearfilter passing

* latest chanegs

* Update CMakeLists.txt

* Update ago_platform.h

* Update vx_api.cpp

* moving #def from VX/include to vx_ext_amd.h

* moving #def from VX/include to vx_ext_amd.h

* adjusting spaces

* moving things from openvx/include to ext_amd

* laplacian update

* disable opencl

* Update CMakeLists.txt

* Update ago_interface.cpp

* Update vx_api.cpp

* LaplacianReconstruct pass

* bug fix

* bracket fix

* remove debug comments

* Update ago_haf_cpu_generic_functions.cpp

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>
kiritigowda added a commit that referenced this pull request Mar 15, 2021
@kiritigowda @LakshmiKumar23
@hansely123 @hansely @paveltc
OpenVX 1.3 Support (#372)
4aeb30f 
* OpenVX 1.3 Headers Added

* Temp Changes to build MIVisionX with OpenVX 1.3 Headers

* VX NN 1.3 Port

* Lk/openvx port 1.3 (#2)

* changes for object-array

* threshold functions & adding objectarray to ago_util

* remap functions

* advanced array functions

* vxCreateMatrixFromPatternAndOrigin

* setImagePixelValues

* OpenVX 1.3 Conformance build

* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* latest changes (#5)

* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* fixes vxGetUserStructNameByEnm and EnumByName

* fixes vxCreateObjectArray and vxCreateVirtualObjectArray

* conformance test nodes

* bug ifx

* declaration added

* threshold functions

* fixes matrix functions

* fixes vxSetImagePixelValues

* fixes remap functions

* threshold typo fix

* changed all of objectarray to replicate delay

* threshold kernels

* weighted average invalid format fix

* fixes vxCreateVirtualScalar

* fixes vxCReateVirtualConvolution

* fixes vxCopyLUT & vxMapLUT

* fixing

* weightedaverage passed

* fix comment

* graph/context/refernce+ fixes

* target base passes all - vx_context

* waitGraph and verifyGraphBase

* undo verifyGraphBase

* nonlinearfilter passing

* latest chanegs

* Update CMakeLists.txt

* Update ago_platform.h

* Update vx_api.cpp

* moving #def from VX/include to vx_ext_amd.h

* moving #def from VX/include to vx_ext_amd.h

* adjusting spaces

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* Lk/port1.3 fix new (#6)

* createvirtualscalar

* vxCreateVirtualConvolution

* syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulDistribution, scalar syntax fix

* vxCreateVirtiaulMatrix

* vxWeightedAverageNode vxuWeightedAverage

* vxNonLinearFilterNode, vxuNonLinearFilter

* vxLaplacianPyramidNode, vxuLaplacianPyramid

* vxLaplacianReconstructNode, vxuLaplacianReconstruct

* type fix

* fixes vxGetUserStructNameByEnm and EnumByName

* fixes vxCreateObjectArray and vxCreateVirtualObjectArray

* conformance test nodes

* bug ifx

* declaration added

* threshold functions

* fixes matrix functions

* fixes vxSetImagePixelValues

* fixes remap functions

* threshold typo fix

* changed all of objectarray to replicate delay

* threshold kernels

* weighted average invalid format fix

* fixes vxCreateVirtualScalar

* fixes vxCReateVirtualConvolution

* fixes vxCopyLUT & vxMapLUT

* fixing

* weightedaverage passed

* fix comment

* graph/context/refernce+ fixes

* target base passes all - vx_context

* waitGraph and verifyGraphBase

* undo verifyGraphBase

* nonlinearfilter passing

* latest chanegs

* Update CMakeLists.txt

* Update ago_platform.h

* Update vx_api.cpp

* moving #def from VX/include to vx_ext_amd.h

* moving #def from VX/include to vx_ext_amd.h

* adjusting spaces

* moving things from openvx/include to ext_amd

* laplacian update

* disable opencl

* Update CMakeLists.txt

* Update ago_interface.cpp

* Update vx_api.cpp

* LaplacianReconstruct pass

* bug fix

* bracket fix

* remove debug comments

* Update ago_haf_cpu_generic_functions.cpp

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* changes from Hansel and threshold changes (#7)

* remove debug comments

* Update ago_haf_cpu_generic_functions.cpp

* changes to threshold

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* OpenVX 1.3 port - Laplacian Pyramid (#8)

* Laplacian pyramid fix (#9)

* LaplacianPyramid Pass

* CMake fix

* Revert change

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* OpenVX Port - fix build failures (#10)

* Revert change

* opencl changes to threshold

* threshold with C code

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* mean std deviation fix  (#11)

* fixes meanstddev

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* user node 20/74 tests passes  (#12)

* usernode 20 out of 74 tests pass

* removing printf statements

* spacing fix

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* USerNode: All tests pass (#13)

* spacing fix

* adding verification path to fix user node

* fixes all tests of the user node

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* SwapImageHandle roi=false cases passes (#14)

* fixes all tests of userNode

* swapImageHandle - roi=false cases

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* Fixes ReplicateNode-ObjectArray (#17)

* swapImageHandle - roi=false cases

* fixes replicateNode object array

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* fixes LUT type=S16 failures (#18)


* fixes LUT failures

Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* H/openvx 1.3 port new (#19)

* wait graph fixed

* deadlock debug

* deadlock fixed

* cmake fix

* comments added

Co-authored-by: LakshmiKumar23 <kumar.lakshmi1994@gmail.com>

* OpenVX 1.3 Fix

* weighted average validation fix

* graphstate fixed

* check fix

* bug fix

* SmokeTestBase.vxReleaseReferenceBase fix (#21)

* SmokeTestBase.vxReleaseReferenceBase fix

* SmokeTestBase.vxSetReferenceName fix

* Graph State - Fix & code cleanup (#22)

* Graph Tests - Fix (#23)

* code cleanup

* user node fixes

* graph state fixes

* smoketestbase - vxRetainReferenceBase fix (#24)

* smoketestbase-vxRetainReferenceBase fix

* histogram - Fix CTS Errors(#25)

* debugging histogram

* histogram fix

* code cleanup

* Resource Release Fix

* OpenVX 1.3 - half scale gaussian (#27)

* halfscalegaussian fix

* code cleanup

* OpenVX 1.3 - smokeTest.vxRetainReference & smokeTestBase.vxSetReferenceName fix (#26)

* vxRetainRef line 371  fix

* vxSetReferenceName fix

* pyramid fixes

* smoke test fixes for dangling references

* resolves all dangling reference issues

* vxUnloadKernels Fix (#28)

* CTS - graph delay with pyramid fix (#29)

* Canny - CTS bug fix (#30)

* divide by 4 when grad size 7

* canny fix

* merge

* canny fix

* code cleanup

* Run OpenVX 1.3 CPU Conformance

* Travis Fix - OpenVX 1.3

* Travis Cleanup

* OpenVX 1.3 - Harris corner CTS Fix (#31)

* CMake

* harris fix

* code cleanup

* swapImageHandle  (#32)

* changing buffers to reflect right values

* getting correct pointers for ROI

* buffer values for multiple plane images

* fixes 12/39 swapImageHandle cases

* fixes all swapImageHandle errors

* fixes color convert  errors (#33)

* fixes conversion from RGBX to NV12&IYUV

* fixes conversion from UYVY to NV12&IYUV

* fixes conversion from YUYV to NV12&IYUV

* fixes converion from NV12,NV21&IYUV to RGBX

* fixes conversion from NV12,NV21&IYUV to RGB

* warp affine - fix (#34)

* warp affine fix

* code cleanup

* Travis - Trace Error

* Travis - Check VGA

* Travis Updates

* Fix - variable scope

* CXX Flags & OpenVX Version Update

* changed Threshold to support new OpenVX 1.3 format (#38)

Co-authored-by: paveltc <pavel.tcherniaev@amd.com>

* Threshold - Update to 1.3

* Jenkins - Check Build & Artifacts

* Tests - Fix platform name

* GPU Fix - multiply gpu (#39)

* CMake

* multiply fix

* code cleanup

* GPU Flow - Canny Fix (#36)

* CMake

* canny fix

* code cleanup

* GPU Flow - Bug Fixes (#35)

* fixes GraphROI.Simple & vxMapRemapPatch.MapRandomRemap

* Graph.GraphState

* fixes Threshold.OnRandom/4/Graph/BINARY/U8/U8

* removing unwanted commits

* fixes Threshold.OnRandom/5/Graph/BINARY/S16/U8

* fixes Threshold.OnRandom/7/Graph/RANGE/S16/U8

* removing unnecessary changes

* GPU Flow - fixes LUT for data type s16 (#40)

* GPU Flow - channel combine (#41)

* channel combine fix

* merge fix

Co-authored-by: LakshmiKumar23 <kumar.lakshmi1994@gmail.com>
Co-authored-by: Hansel Yang <hanselyang123@gmail.com>
Co-authored-by: Kiriti Gowda <kiriti@Kiritis-MacBook-Pro.local>
Co-authored-by: LakshmiKumar23 <lakshmi.kumar@amd.com>
Co-authored-by: Hansel Yang <hansyang@amd.com>
Co-authored-by: Kiriti Nagesh Gowda <kiritigowda@Kiritis-MacBook-Pro.local>
Co-authored-by: Pavel Tcherniaev <ptcherni@amd.com>
Co-authored-by: paveltc <pavel.tcherniaev@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther approved these changes

Assignees
No one assigned
Labels
bugfix Bug fixes to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiritigowda @jlgreathouse @rrawther