-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature token vbl simplification #1307
Merged
Phergus
merged 186 commits into
RPTools:feature-token-vbl-simplification
from
JamzTheMan:feature-token-vbl-simplification
Feb 22, 2020
Merged
Feature token vbl simplification #1307
Phergus
merged 186 commits into
RPTools:feature-token-vbl-simplification
from
JamzTheMan:feature-token-vbl-simplification
Feb 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.5.8
Bumps [okhttp](https://github.com/square/okhttp) from 4.2.2 to 4.3.0. - [Release notes](https://github.com/square/okhttp/releases) - [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - [Commits](square/okhttp@parent-4.2.2...parent-4.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…http3-okhttp-4.3.0
Release 1.5.9
…http3-okhttp-4.3.0
…http3-okhttp-4.3.0
…http3-okhttp-4.3.0
…http3-okhttp-4.3.0
…http3-okhttp-4.3.0
Bug fix for NPE when Hero Lab XML data missing
Fixes problem with extension not being always added to Campaign filename in Export and Save
Updated with RPTools#1296
Removes the empty space at the bottom of input() dialog
- Fix similar issues for "light", "propertyType", and "owner" options - Fix RPTools#1292
Fix for copyTokens when used w/o updates parameter. Fix for spurious output when updates parameter is used. Changed a couple error messages to use I18N strings. Refactored deleteToken() as it didn't need/use MapTooVariableResolver.
New Crowdin translations
Update TokenCopyDeleteFunctions.java
Pull changes from Release 1.5.13 back to develop.
…/RPTools/maptool into feature-token-vbl-simplification
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Phergus
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 96 of 96 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @cwisniew)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP but a lot farther along. A lot easier to test the optimizations now...
Merging to feature branch still until complete.
(note most of these changes are to bring the feature branch current with develop)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)