Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature token vbl simplification #1307

Conversation

JamzTheMan
Copy link
Member

@JamzTheMan JamzTheMan commented Feb 22, 2020

Still WIP but a lot farther along. A lot easier to test the optimizations now...

Merging to feature branch still until complete.

(note most of these changes are to bring the feature branch current with develop)


This change is Reviewable

JamzTheMan and others added 30 commits December 12, 2019 18:10
Phergus and others added 21 commits February 18, 2020 19:23
Bug fix for NPE when Hero Lab XML data missing
Fixes problem with extension not being always added to Campaign filename in Export and Save
Removes the empty space at the bottom of input() dialog
- Fix similar issues for "light", "propertyType", and "owner" options
- Fix RPTools#1292
Fix for copyTokens when used w/o updates parameter.  Fix for spurious output when updates parameter is used.  Changed a couple error messages to use I18N strings. Refactored deleteToken() as it didn't need/use MapTooVariableResolver.
Pull changes from Release 1.5.13 back to develop.
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
@JamzTheMan JamzTheMan added the feature Adding functionality that adds value label Feb 22, 2020
@JamzTheMan JamzTheMan self-assigned this Feb 22, 2020
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 96 of 96 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cwisniew)

@Phergus Phergus merged commit a4fe35f into RPTools:feature-token-vbl-simplification Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants