Skip to content

Conversation

@david-rfai
Copy link
Collaborator

Changes

Testing

  • Ran E2E of FIQA notebook

Screenshots (if applicable)

Screenshot 2025-11-20 at 2 53 54 AM Screenshot 2025-11-20 at 3 48 21 AM Screenshot 2025-11-20 at 3 48 38 AM

Note

Compute final metrics for all non-deleted/non-failed runs, clone pipelines using original user param dicts, and make the progress display more robust; tutorials switch tokenizer padding to right.

  • Evals/Scheduler:
    • Compute final metrics for pipelines with statuses COMPLETED, STOPPED, and ONGOING; skip DELETED and FAILED in _compute_final_metrics_for_pipelines.
    • Preserve and reorder cumulative metrics with added pipeline info; update progress display with final metrics.
  • Interactive Control (Clone):
    • For vllm and openai, source parent configs from _user_params (e.g., model_config, sampling_params, client/rate limits) before applying JSON edits.
    • Extract sampling params for display from _user_params.
  • Progress Display:
    • Add defensive checks (skip missing pipeline data), default missing model to -, and ensure pandas shows all columns in start/stop/_render.
  • Experiment API:
    • Update run_evals return docstring to clarify included/excluded run statuses.
  • Tutorial Notebooks:
    • Change tokenizer padding_side to right across DPO/GRPO notebooks and minor copy updates.

Written by Cursor Bugbot for commit ac051f2. This will update automatically on new commits. Configure here.

@david-rfai david-rfai requested a review from arun-rfai November 21, 2025 23:44
@david-rfai david-rfai merged commit 8351571 into main Nov 21, 2025
@david-rfai david-rfai deleted the bugfix/ic-ops-issues branch November 21, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants