-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Open
Labels
Description
This is a tracking bug for open (or recently-closed) bugs that are related to events.
Event-related issues affecting correctness
Most of these bugs represent situations where undo/redo will fail or not work as intended, and where the minimap plugin and/or mirror demo will get out-of-sync with the main workspace.
BlockChangemutationevents not fired in the correct order and/or at all #1036- Block.removeInput Doesn't Fire Change Event #1717
- Performance and cost of filtering events #1891
- Notes correctness problems caused by reordering some events.
- controls_if: Mutation actions do not undo correctly #2037
- Root cause is
BlockChangeevent ordering. Has been fixed multiple times.
- Root cause is
- Block change events from boolean fields can't be grouped. #6456
- Mutated
procedures_ifreturndetaches child block, but undoing doesn't reattach it. #7950- root cause is invalid state but there are other event-related aspects too.
- Issue with mirroring workspace #8225
- Root cause is
BlockChangeevent ordering.
- Root cause is
- Illegal program state occurs due to belated enforcement by
onchangemethods #8467 - Some
FieldDropdownchanges don't fireBlockChangeevents #8556
Event-related issues with other user-visible effects
These bugs do not affect state correctness but have other user-visible behaviour impact.
- Empty action is added to the undo stack when dragging block directly from the toolbox to trash #1458
- Do not record undo for no operation. #1884
- Dupe.
- undo management: separate blocky and browser #1915
- Relates to behaviour of undo but doesn't affect state-correctness from Blockly's point of view.
- Call to setFieldValue triggered on Create causes rendering issues #3773
- Provisionally classified as not state-correctness affecting as it appears that only shadow block is incorrect.
- Undo/Redo with create/delete events does not trigger animations #5438
Event-related issues without user-visible effect
These are mostly refactor / cleanup feature requests.
- Omit unused event arguments on event handler functions? #1770
- Change event element registry #3793
- Originally proposed adding a registry for event classes—but see Events and event API definition and documentation #6632 for arguments against.
- Test serialization/deserialization of move event coordinates #4577
- Add onfocus and onblur event for workspace #4822
- Turn Events.recordUndo into a counter like Events.disable() #5292
- Clean up Blockly BlockChange Events #5397
- Proposed breaking
BlockChangeup into multiple subclasses.
- Proposed breaking
- Fix types for event properties #5927
- Post-TS-migration type-cleanup bug; proposes more use of
instanceof.
- Post-TS-migration type-cleanup bug; proposes more use of
- Events and event API definition and documentation #6632
- Discusses various changes to event architecture (including elimination of use of the registry for event creation), which could allow more use of
instanceof.
- Discusses various changes to event architecture (including elimination of use of the registry for event creation), which could allow more use of
- Workspace comment events should not have public properties with underscores. #6774
- Events cannot be fired from block initialization #6840
Other event-related issues
I have not yet investigated these sufficiently to classify into one of the above sections.