Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots: fix Fastlane job #1461

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Snapshots: fix Fastlane job #1461

merged 2 commits into from
Nov 10, 2023

Conversation

NachoSoto
Copy link
Contributor

fastlane update_snapshots_commit was failing without this

@NachoSoto NachoSoto added the ci label Nov 10, 2023
@NachoSoto NachoSoto requested a review from tonidero November 10, 2023 17:10
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NachoSoto NachoSoto enabled auto-merge (squash) November 10, 2023 17:34
@NachoSoto NachoSoto merged commit 990c1d8 into main Nov 10, 2023
@NachoSoto NachoSoto deleted the fastlane-snapshot-job-fix branch November 10, 2023 17:50
NachoSoto pushed a commit that referenced this pull request Nov 14, 2023
**This is an automatic release.**

### RevenueCatUI
* Paywalls: fix template 5 header aspect ratio (#1465) via NachoSoto
(@NachoSoto)
* Paywalls: Fix template 1 header aspect ratio (#1466) via Toni Rico
(@tonidero)
* Paywalls: Support condensed footer in template 4 (#1469) via Toni Rico
(@tonidero)
* `Paywalls`: improve image loading (#1464) via NachoSoto (@NachoSoto)
* `Paywalls`: override locale with paywall localization (#1418) via
NachoSoto (@NachoSoto)
### Other Changes
* Paywalls: Fix purchasing regression by providing real activity (#1467)
via Toni Rico (@tonidero)
* Bump compile/target version to 34 (#1462) via Toni Rico (@tonidero)
* Update circleci orb to latest version (#1456) via Toni Rico
(@tonidero)
* `Snapshots`: fix Fastlane job (#1461) via NachoSoto (@NachoSoto)
* Update gradle plugin to version 8.1.1 (#1458) via Toni Rico
(@tonidero)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
@vegaro vegaro added pr:other and removed pr:ci labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (f479dd8) to head (ce31418).
Report is 297 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         208      208           
  Lines        6893     6893           
  Branches      999      999           
=======================================
  Hits         5785     5785           
  Misses        714      714           
  Partials      394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants