Paywalls: fix template 5 header aspect ratio #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 208 208
Lines 6893 6893
Branches 999 999
=======================================
Hits 5785 5785
Misses 714 714
Partials 394 394 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Nov 14, 2023
ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/templates/Template5.kt
Outdated
Show resolved
Hide resolved
|
Actually, I wonder about why the snapshot tests are not failing... seems like there might be something wrong there... Will take a look. |
NachoSoto
changed the title
Paywalls: fix template 5 header aspect ratio
tonidero
added a commit
that referenced
this pull request
Nov 14, 2023
### Description Similar to #1465 but in template 1. This was caused by a bad refactor when extracting the `aspectRatio` calculation to an extension.
It was entering the == 0 branch, so we can merge this 👍 |
NachoSoto
pushed a commit
that referenced
this pull request
Nov 14, 2023
**This is an automatic release.** ### RevenueCatUI * Paywalls: fix template 5 header aspect ratio (#1465) via NachoSoto (@NachoSoto) * Paywalls: Fix template 1 header aspect ratio (#1466) via Toni Rico (@tonidero) * Paywalls: Support condensed footer in template 4 (#1469) via Toni Rico (@tonidero) * `Paywalls`: improve image loading (#1464) via NachoSoto (@NachoSoto) * `Paywalls`: override locale with paywall localization (#1418) via NachoSoto (@NachoSoto) ### Other Changes * Paywalls: Fix purchasing regression by providing real activity (#1467) via Toni Rico (@tonidero) * Bump compile/target version to 34 (#1462) via Toni Rico (@tonidero) * Update circleci orb to latest version (#1456) via Toni Rico (@tonidero) * `Snapshots`: fix Fastlane job (#1461) via NachoSoto (@NachoSoto) * Update gradle plugin to version 8.1.1 (#1458) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After