Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: Support condensed footer in template 4 #1469

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

tonidero
Copy link
Contributor

Description

Template 4 did not support condensed footer mode. This adds it with a simple slide up-down animation.

Screen_recording_20231114_152339.mp4

textAlign = TextAlign.Center,
modifier = Modifier.fillMaxWidth(),
)
Column(horizontalAlignment = Alignment.CenterHorizontally) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to wrap these into another column like this to avoid the outer column verticalArrangement spacing. Seems like the AnimatedVisibility jumps when trying to animate an item disappearing and that spacing going away. I'm mimicking that by manually handling the animation of a custom Spacer here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the AnimatedVisibility jumps when trying to animate an item disappearing and that spacing going away

Yeah that's why we can't use it in many place where e need spacing to remain consistent.

@tonidero tonidero marked this pull request as ready for review November 14, 2023 14:25
@tonidero tonidero requested a review from a team November 14, 2023 14:25
@tonidero tonidero enabled auto-merge (squash) November 14, 2023 14:58
@tonidero tonidero merged commit d558c53 into main Nov 14, 2023
@tonidero tonidero deleted the support-condensed-footer-template-4 branch November 14, 2023 15:15
NachoSoto pushed a commit that referenced this pull request Nov 14, 2023
**This is an automatic release.**

### RevenueCatUI
* Paywalls: fix template 5 header aspect ratio (#1465) via NachoSoto
(@NachoSoto)
* Paywalls: Fix template 1 header aspect ratio (#1466) via Toni Rico
(@tonidero)
* Paywalls: Support condensed footer in template 4 (#1469) via Toni Rico
(@tonidero)
* `Paywalls`: improve image loading (#1464) via NachoSoto (@NachoSoto)
* `Paywalls`: override locale with paywall localization (#1418) via
NachoSoto (@NachoSoto)
### Other Changes
* Paywalls: Fix purchasing regression by providing real activity (#1467)
via Toni Rico (@tonidero)
* Bump compile/target version to 34 (#1462) via Toni Rico (@tonidero)
* Update circleci orb to latest version (#1456) via Toni Rico
(@tonidero)
* `Snapshots`: fix Fastlane job (#1461) via NachoSoto (@NachoSoto)
* Update gradle plugin to version 8.1.1 (#1458) via Toni Rico
(@tonidero)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants