Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --config=omp when building GCC + Everything #154

Merged
merged 1 commit into from
May 5, 2022
Merged

Use --config=omp when building GCC + Everything #154

merged 1 commit into from
May 5, 2022

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented May 5, 2022 •
edited
Loading

@jwnimmer-tri jwnimmer-tri changed the title Use --config omp when building GCC + Everything Use --config=omp when building GCC + Everything May 5, 2022
@jwnimmer-tri
Copy link
Contributor Author

@BetsyMcPhail or @svenevs for review, please?

I've launched a test of this PR here:

https://drake-jenkins.csail.mit.edu/view/Everything/job/linux-focal-gcc-bazel-experimental-everything-release/483/console

svenevs
svenevs approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

[1:54:27 PM]  Checking out Revision 1e524ced9d40a8d8e985565428c3423fd2b36fcd (detached)
[1:54:27 PM]  Commit message: "Use --config omp when building GCC + Everything"

Job using this PR succeeded in running bazel test --config gcc --compilation_mode=opt --config=everything --config=omp ....

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BetsyMcPhail)

@jwnimmer-tri
Copy link
Contributor Author

Yup. I also confirmed that we see -fopenmp in the console output.

@svenevs svenevs merged commit bce6e52 into RobotLocomotion:main May 5, 2022
@jwnimmer-tri jwnimmer-tri deleted the omp branch May 5, 2022 20:20
@jwnimmer-tri jwnimmer-tri mentioned this pull request May 11, 2022
Merged
jwnimmer-tri added a commit that referenced this pull request May 11, 2022
@jwnimmer-tri
Revert "Use --config omp when building GCC + Everything (#154)"
3538740 
This reverts commit bce6e52.
@jwnimmer-tri jwnimmer-tri mentioned this pull request May 11, 2022
Merged
svenevs pushed a commit that referenced this pull request May 11, 2022
@jwnimmer-tri
Revert "Use --config omp when building GCC + Everything (#154)" (#156)
aaa76df 
This reverts commit bce6e52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenevs svenevs svenevs approved these changes

@BetsyMcPhail BetsyMcPhail Awaiting requested review from BetsyMcPhail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnimmer-tri @svenevs