Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] Add OpenMP to "Everything" CI config #17154

Merged
merged 1 commit into from
May 11, 2022
Merged

[tools] Add OpenMP to "Everything" CI config #17154

merged 1 commit into from
May 11, 2022

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented May 11, 2022 •
edited
Loading

Towards #14858.

Previously, it was only enabled manually for GCC only (RobotLocomotion/drake-ci#154). Now that we are up to Clang 12, we can enable it unconditionally (and thereafter revert that CI PR).

This change is Reviewable

@jwnimmer-tri
[tools] Add OpenMP to "Everything" CI config
2ef450f 
Previously, it was only enabled manually for GCC only.
Now that we are up to Clang 12, we can enable it unconditionally.
@jwnimmer-tri jwnimmer-tri added priority: medium status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels May 11, 2022
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-address-sanitizer please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-coverage please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-debug please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-leak-sanitizer please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-thread-sanitizer please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-undefined-behavior-sanitizer please
@drake-jenkins-bot linux-focal-clang-bazel-experimental-everything-valgrind-memcheck please

@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for both reviews, please.

rpoyner-tri
rpoyner-tri reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)

rpoyner-tri
rpoyner-tri reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x 2 pending build results.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit 3f7d5aa into RobotLocomotion:master May 11, 2022
@jwnimmer-tri jwnimmer-tri deleted the omp-ci branch May 11, 2022 15:13
@jwnimmer-tri jwnimmer-tri mentioned this pull request May 11, 2022
Merged
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request May 27, 2022
@jwnimmer-tri @aykut-tri
[tools] Add OpenMP to "Everything" CI config (RobotLocomotion#17154)
9996fc0 
Previously, it was only enabled manually for GCC only.
Now that we are up to Clang 12, we can enable it unconditionally.
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request Jun 1, 2022
@jwnimmer-tri @aykut-tri
[tools] Add OpenMP to "Everything" CI config (RobotLocomotion#17154)
608c752 
Previously, it was only enabled manually for GCC only.
Now that we are up to Clang 12, we can enable it unconditionally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpoyner-tri rpoyner-tri rpoyner-tri left review comments

Assignees

@rpoyner-tri rpoyner-tri

Labels
priority: medium release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnimmer-tri @rpoyner-tri