Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind: Should separate out fork-specific tests; check feature parity w/ smart_holder approach #14838

Closed
EricCousineau-TRI opened this issue Mar 29, 2021 · 0 comments
Closed

pybind: Should separate out fork-specific tests; check feature parity w/ smart_holder approach #14838

EricCousineau-TRI opened this issue Mar 29, 2021 · 0 comments
Assignees
@EricCousineau-TRI
Labels
component: pydrake Python API and its supporting Starlark macros priority: low type: cleanup

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Mar 29, 2021 •
edited
Loading

Per VC today w/ @rwgk and @rhaschke
Relates third-party goals outlined in pybind/pybind11#2646
Relates first-party goal in #5842

Citing action item per (private) meeting notes:

Eric: Cull out Drake-specific fork tests. Figure out min. delta to identify feature parity (or identiy what's necessary for it).

Branch for parity checks: https://github.com/pybind/pybind11/tree/smart_holder
Will use PYBIND11_USE_SMART_HOLDER_AS_DEFAULT for simplicity.

Hoping to sneak this in as part of incidental work next Q.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricCousineau-TRI EricCousineau-TRI

Labels
component: pydrake Python API and its supporting Starlark macros priority: low type: cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwnimmer-tri @EricCousineau-TRI