Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tolerance of Convex in ProximityEngine #9512

Closed
DamrongGuoy opened this issue Sep 25, 2018 · 7 comments
Closed

Check tolerance of Convex in ProximityEngine #9512

DamrongGuoy opened this issue Sep 25, 2018 · 7 comments
Assignees
Labels
component: geometry proximity Contact, distance, signed distance queries and related properties unused team: dynamics

Comments

@DamrongGuoy
Copy link
Contributor

Follow up to #9471, when I set up a unit test for ProximityEngine using Convex, I found that I need to use tolerance 1e-3. I'd like to check why we cannot use smaller tolerance.

@DamrongGuoy DamrongGuoy self-assigned this Sep 25, 2018
@DamrongGuoy DamrongGuoy added the component: geometry proximity Contact, distance, signed distance queries and related properties label Sep 30, 2020
@DamrongGuoy
Copy link
Contributor Author

Not needed anymore. Close.

@SeanCurtis-TRI
Copy link
Contributor

@DamrongGuoy Can you indicate why it's not needed anymore? The answer isn't clear to me.

@DamrongGuoy
Copy link
Contributor Author

The reason is no users of drake complained about it. If you'd like it investigated, I'll be happy to reopen.

@sherm1
Copy link
Member

sherm1 commented Oct 1, 2020

It's not clear to me that users would notice if this caused problems. For example, their simulations might just run slowly because of instability caused by noise in the contact results. But they wouldn't know that this was the cause. I still think we should understand (and ideally fix) the low accuracy here. But I agree the priority could be low since we don't have obvious consequences for this yet (maybe not many people are using convex meshes yet?).

@DamrongGuoy
Copy link
Contributor Author

Thank you. I reopen now.

@DamrongGuoy DamrongGuoy reopened this Oct 1, 2020
@SeanCurtis-TRI
Copy link
Contributor

As I've pondered this, it seems that there are three sub-issues at play here:

  1. Publishing the fact that tolerance sucks such that customers can make informed decisions. This is part of issue Document geometry query result precision #10907 -- part of my Q4 OKRs to resolve.
  2. Investigating why the tolerance is bad as it appears to be. That seems to be what the language of this issue is about.
  3. Improving precision. Some unknown blob of work (most likely related GJK/EPA).

As @DamrongGuoy indicated, no one has complained about apparent precision woes. But as @sherm1 has pointed out, they may not know to complain.

It seems reasonable to close this issue in favor of #10907. With information, customers might be more able to complain (although we don't have many users that use Convex).

I would advocate that if we keep this issue open, we need to elaborate the issue summary. A link to the PR doesn't seem sufficient -- it would require a great deal of spelunking by future readers to understand what the actual code in question is. Leaving the link as support of the issue description is fine, but the actual issue should be spelled out more explicitly.

@DamrongGuoy
Copy link
Contributor Author

I agree with Sean. Close this issue in favor of #10907.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: geometry proximity Contact, distance, signed distance queries and related properties unused team: dynamics
Projects
None yet
Development

No branches or pull requests

4 participants