-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check tolerance of Convex in ProximityEngine #9512
Comments
Not needed anymore. Close. |
@DamrongGuoy Can you indicate why it's not needed anymore? The answer isn't clear to me. |
The reason is no users of drake complained about it. If you'd like it investigated, I'll be happy to reopen. |
It's not clear to me that users would notice if this caused problems. For example, their simulations might just run slowly because of instability caused by noise in the contact results. But they wouldn't know that this was the cause. I still think we should understand (and ideally fix) the low accuracy here. But I agree the priority could be low since we don't have obvious consequences for this yet (maybe not many people are using convex meshes yet?). |
Thank you. I reopen now. |
As I've pondered this, it seems that there are three sub-issues at play here:
As @DamrongGuoy indicated, no one has complained about apparent precision woes. But as @sherm1 has pointed out, they may not know to complain. It seems reasonable to close this issue in favor of #10907. With information, customers might be more able to complain (although we don't have many users that use I would advocate that if we keep this issue open, we need to elaborate the issue summary. A link to the PR doesn't seem sufficient -- it would require a great deal of spelunking by future readers to understand what the actual code in question is. Leaving the link as support of the issue description is fine, but the actual issue should be spelled out more explicitly. |
I agree with Sean. Close this issue in favor of #10907. |
Follow up to #9471, when I set up a unit test for ProximityEngine using Convex, I found that I need to use tolerance 1e-3. I'd like to check why we cannot use smaller tolerance.
The text was updated successfully, but these errors were encountered: