-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geometry: Improve data representation of convex meshes in ProximityEngine #9553
Comments
FYI @SeanCurtis-TRI per your recent work on convex & fcl. |
Actually, if we haven't cared about this in the past 6 years, I'll venture a guess that it's not important anymore, so closing as "not planned". |
Ironically, it's in the midst of being kind of addressed with #21147.
|
We would like to improve data representation of convex meshes in ProximityEngine. The data is needed by fcl::Convex. The improvement includes
ConvexData
from astruct
to ashared_ptr
ofstruct
.convex_objects_
from avector
ofConvexData
to amap
fromfilename
toConvexData
.convex_objects_
in the copy constructor of ProximityEngine::Impl.Improvement 1 is in anticipation of the future fcl::Convex constructor that will take
shared_ptr.
Improvement 2 will optimize instantiation of multiple objects of the same shape from the same file.
Improvement 3 is to prevent a potential problem introduced by #9471.
The text was updated successfully, but these errors were encountered: