Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry: Improve data representation of convex meshes in ProximityEngine #9553

Closed
DamrongGuoy opened this issue Sep 28, 2018 · 3 comments
Closed
Assignees
Labels
component: geometry proximity Contact, distance, signed distance queries and related properties priority: medium type: feature request

Comments

@DamrongGuoy
Copy link
Contributor

We would like to improve data representation of convex meshes in ProximityEngine. The data is needed by fcl::Convex. The improvement includes

  1. Change ConvexData from a struct to a shared_ptr of struct.
  2. Change convex_objects_ from a vector of ConvexData to a map from filename to ConvexData.
  3. Copy convex_objects_ in the copy constructor of ProximityEngine::Impl.

Improvement 1 is in anticipation of the future fcl::Convex constructor that will take shared_ptr.
Improvement 2 will optimize instantiation of multiple objects of the same shape from the same file.
Improvement 3 is to prevent a potential problem introduced by #9471.

@DamrongGuoy DamrongGuoy self-assigned this Sep 28, 2018
@sherm1 sherm1 changed the title geometrty: Improve data representation of convex meshes in ProximityEngine geometry: Improve data representation of convex meshes in ProximityEngine May 12, 2020
@DamrongGuoy DamrongGuoy added the component: geometry proximity Contact, distance, signed distance queries and related properties label Sep 30, 2020
@jwnimmer-tri
Copy link
Collaborator

FYI @SeanCurtis-TRI per your recent work on convex & fcl.

@jwnimmer-tri
Copy link
Collaborator

Actually, if we haven't cared about this in the past 6 years, I'll venture a guess that it's not important anymore, so closing as "not planned".

@jwnimmer-tri jwnimmer-tri closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@SeanCurtis-TRI
Copy link
Contributor

Ironically, it's in the midst of being kind of addressed with #21147.

Mesh and Convex now have a unique representation of their convex hull which has a direct mapping to fcl::Convexd. The only thing we're really missing is a geometry cache so we don't have to parse the same file over and over. But that's a known, long-lasting thing that doesn't need an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: geometry proximity Contact, distance, signed distance queries and related properties priority: medium type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants