tools: Remove duplicate linking #12310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once we turn off incompatible_remove_legacy_whole_archive, these duplicate symbols become errors.
|
To match the reviewers on #12262, let's do: Note that most of these changes have already been seen in #12262. The new changes as of this PR are in
|
jamiesnape
reviewed
Nov 4, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri)
sammy-tri
reviewed
Nov 4, 2019
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),jamiesnape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we turn off incompatible_remove_legacy_whole_archive, these duplicate symbols become errors.
This is a pre-requisite for #12262.
This change is