Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Temporarily disable OpenUSD testing #20994

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 20, 2024

@jwnimmer-tri jwnimmer-tri added priority: emergency status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Feb 20, 2024
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-jammy-unprovisioned-gcc-bazel-experimental-everything-release please

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@ggould-tri for both reviews please

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee ggould-tri(platform)

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion


tools/workspace/openusd_internal/BUILD.bazel line 32 at r1 (raw file):

    args = ["--help"],
    tags = [
        # TODO(jwnimmer-tri) Re-enable this once we fix Boost problems.

minor: I don't know what "Boost problems" this means; should this be TODO to an issue or is this something that's going to be resolved very quickly and so there's no chance of losing context?

Code quote:

Boost problems

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)


tools/workspace/openusd_internal/BUILD.bazel line 32 at r1 (raw file):

Previously, ggould-tri wrote…

minor: I don't know what "Boost problems" this means; should this be TODO to an issue or is this something that's going to be resolved very quickly and so there's no chance of losing context?

I don't anticipate any meaningful confusion or loss.

@jwnimmer-tri jwnimmer-tri merged commit 54ce513 into RobotLocomotion:master Feb 20, 2024
11 checks passed
@jwnimmer-tri jwnimmer-tri deleted the openusd-manual branch February 20, 2024 17:36
@jwnimmer-tri jwnimmer-tri mentioned this pull request Feb 21, 2024
22 tasks
jwnimmer-tri added a commit to jwnimmer-tri/drake that referenced this pull request Apr 1, 2024
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: emergency release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants