Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onetbb] Hotfix for include path hijinks #21058

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 27, 2024

The OneTBB headers are internally inconsistent about how they should include themselves. We need to provide both paths to keep them happy.

Amends #20923.


This change is Reviewable

The OneTBB headers are internally inconsistent about how they should
include themselves. We need to provide both paths to keep them happy.
@jwnimmer-tri jwnimmer-tri added priority: high status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Feb 27, 2024
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-jammy-unprovisioned-gcc-bazel-experimental-everything-release please

@ggould-tri ggould-tri self-assigned this Feb 27, 2024
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is past the point where it would have failed.
+@ggould-tri :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review February 27, 2024 18:52
@jwnimmer-tri jwnimmer-tri merged commit 5a6c3e3 into RobotLocomotion:master Feb 27, 2024
11 checks passed
@jwnimmer-tri jwnimmer-tri deleted the hotfix-tbb-includes branch February 27, 2024 18:52
@jwnimmer-tri jwnimmer-tri mentioned this pull request Feb 27, 2024
22 tasks
jwnimmer-tri added a commit to jwnimmer-tri/drake that referenced this pull request Apr 1, 2024
The OneTBB headers are internally inconsistent about how they should
include themselves. We need to provide both paths to keep them happy.
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
The OneTBB headers are internally inconsistent about how they should
include themselves. We need to provide both paths to keep them happy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants