Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade scs_internal to latest release 3.2.7 #21797

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Aug 8, 2024

The commit message subject line should be the PR title.

The commit message body should be empty (except for any authorship credits).

Towards #21759.

This skips over 3.2.6, where we reported a bug upstream at cvxgrp/scs#284.


This change is Reviewable

@BetsyMcPhail
Copy link
Contributor Author

@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please.

@BetsyMcPhail BetsyMcPhail mentioned this pull request Aug 8, 2024
8 tasks
@jwnimmer-tri jwnimmer-tri self-assigned this Aug 12, 2024
@jwnimmer-tri
Copy link
Collaborator

FYI I can look at this next week, unless someone else wants to beat me to it. (I don't think it's any particular hurry.)

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Aug 22, 2024
@jwnimmer-tri
Copy link
Collaborator

@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)

@jwnimmer-tri
Copy link
Collaborator

+@hongkai-dai for feature review please (in particular the norm_inf.patch).

+@xuchenhan-tri for platform review per schedule, please.

Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),hongkai-dai,xuchenhan-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),hongkai-dai,xuchenhan-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)

@jwnimmer-tri jwnimmer-tri removed their assignment Aug 22, 2024
@jwnimmer-tri
Copy link
Collaborator

@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please

Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignees hongkai-dai,xuchenhan-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)

Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm:

Reviewable status: LGTM missing from assignee hongkai-dai, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)

@jwnimmer-tri
Copy link
Collaborator

@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please

@jwnimmer-tri
Copy link
Collaborator

-@hongkai-dai no longer needed, upstream has accepted the patch.

@jwnimmer-tri jwnimmer-tri changed the title [workspace] Upgrade scs_internal to latest release 3.2.6 [workspace] Upgrade scs_internal to latest release 3.2.7 Aug 26, 2024
@jwnimmer-tri jwnimmer-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Aug 26, 2024
@jwnimmer-tri jwnimmer-tri merged commit 30b3e85 into RobotLocomotion:master Aug 26, 2024
8 of 10 checks passed
@BetsyMcPhail BetsyMcPhail deleted the update-scs_internal branch August 26, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants