-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Upgrade scs_internal to latest release 3.2.7 #21797
[workspace] Upgrade scs_internal to latest release 3.2.7 #21797
Conversation
@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please. |
FYI I can look at this next week, unless someone else wants to beat me to it. (I don't think it's any particular hurry.) |
@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
+@hongkai-dai for feature review please (in particular the +@xuchenhan-tri for platform review per schedule, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),hongkai-dai,xuchenhan-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),hongkai-dai,xuchenhan-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: LGTM missing from assignees hongkai-dai,xuchenhan-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: LGTM missing from assignee hongkai-dai, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @BetsyMcPhail)
@drake-jenkins-bot linux-jammy-clang-bazel-experimental-everything-address-sanitizer please |
-@hongkai-dai no longer needed, upstream has accepted the patch. |
The commit message subject line should be the PR title.
The commit message body should be empty (except for any authorship credits).
Towards #21759.
This skips over 3.2.6, where we reported a bug upstream at cvxgrp/scs#284.
This change is