Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drake_{lcm,proto}.bzl in tools/skylark #7279

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 17, 2017

Relates #6996.

The intention here is to provide stable wrapper APIs that will allow us to evolve the build system without touching all of our user code. That's mostly intended for #include path changes coming in #6996, but will also likely help with #7278.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the build-drake-folder-6996-pr24d branch 2 times, most recently from e61dbc6 to e32a7c7 Compare October 17, 2017 15:56
@jwnimmer-tri
Copy link
Collaborator Author

+@soonho-tri for feature review please?
+@sammy-tri for platform review please, per rotation.

@soonho-tri
Copy link
Member

:lgtm:


Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sammy-tri
Copy link
Contributor

:lgtm:


Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sammy-tri sammy-tri merged commit fb87f99 into RobotLocomotion:master Oct 17, 2017
@jwnimmer-tri jwnimmer-tri deleted the build-drake-folder-6996-pr24d branch October 17, 2017 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants