Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor pkg_config_repository calls into bzl helpers #7738

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 11, 2018

Relates #7259.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the bazel-reuse-workspace-pr5 branch 2 times, most recently from 973d49a to d352ec4 Compare January 11, 2018 19:34
@jwnimmer-tri
Copy link
Collaborator Author

+@soonho-tri for all review per schedule, please.

I will test on macOS CI prior to merging, after #7733 lands first.

@soonho-tri
Copy link
Member

:lgtm:


Reviewed 30 of 30 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


WORKSPACE, line 47 at r1 (raw file):

# This local repository imports the protobuf build rules for Bazel (based on
# the upstream protobuf.bzl build rules); in constrast, the protobuf runtime is

I think this one (@libprotobuf) and the one below (@com_google_protobuf) were swapped by accident?


Comments from Reviewable

@soonho-tri
Copy link
Member

Review status: all files reviewed at latest revision, all discussions resolved.


WORKSPACE, line 47 at r1 (raw file):

Previously, soonho-tri (Soonho Kong) wrote…

I think this one (@libprotobuf) and the one below (@com_google_protobuf) were swapped by accident?

Never mind. I just got confused.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


WORKSPACE, line 47 at r1 (raw file):

Previously, soonho-tri (Soonho Kong) wrote…

Never mind. I just got confused.

OK Yeah, diff tools really struggle with PRs like this (I have a few more in the queue that are similarly scattered.)


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the bazel-reuse-workspace-pr5 branch from d352ec4 to 4d95df4 Compare January 12, 2018 00:21
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-sierra-clang-bazel-experimental please
@drake-jenkins-bot mac-sierra-clang-cmake-experimental-matlab please
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please
@drake-jenkins-bot mac-highsierra-clang-cmake-experimental please

@jwnimmer-tri jwnimmer-tri merged commit 968ca82 into RobotLocomotion:master Jan 12, 2018
@jwnimmer-tri jwnimmer-tri deleted the bazel-reuse-workspace-pr5 branch January 12, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants