Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite maven rules to use java_import_external #7739

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Rewrite maven rules to use java_import_external #7739

merged 1 commit into from
Jan 12, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 11, 2018 •
edited by sherm1
Loading

This is Bazel's new best practice. Most acutely for us, it allows for multiple mirror URLs to be used.

Here we also update the repository names to match upstream's latest recommendations for mapping maven names into repository names.

Relates #7259.

This change is Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the bazel-reuse-workspace-pr6 branch from 2bdc412 to 06a1744 Compare January 11, 2018 21:08
@jwnimmer-tri
Copy link
Collaborator Author

+@jamiesnape for feature review, please.
+@soonho-tri for platform review per schedule, please.

@jwnimmer-tri jwnimmer-tri force-pushed the bazel-reuse-workspace-pr6 branch 2 times, most recently from ce3ba05 to 87e9da3 Compare January 12, 2018 02:41
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-sierra-clang-bazel-experimental please
@drake-jenkins-bot mac-highsierra-clang-cmake-experimental please

@jamiesnape
Copy link
Contributor

:lgtm:

Reviewed 18 of 18 files at r1, 3 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

tools/workspace/maven.bzl, line 6 at r2 (raw file):

MAVEN_BASE_URLS = [
    "https://jcenter.bintray.com/",
    "http://repo1.maven.org/maven2/",

BTW https

Comments from Reviewable

@soonho-tri
Copy link
Member

:lgtm:

Reviewed 16 of 18 files at r1, 3 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@jwnimmer-tri
Rewrite maven rules to use java_import_external
c951567 
This is Bazel's new best practice.  Most acutely for us, it allows
for multiple mirror URLs to be used.

Here we also update the repository names to match upstream's latest
recommendations for mapping maven names into repository names.
@jwnimmer-tri jwnimmer-tri force-pushed the bazel-reuse-workspace-pr6 branch from 87e9da3 to c951567 Compare January 12, 2018 16:17
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-sierra-clang-bazel-experimental please
@drake-jenkins-bot mac-sierra-clang-cmake-experimental-matlab please
@drake-jenkins-bot mac-highsierra-clang-cmake-experimental please

@soonho-tri
Copy link
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit 364a1a2 into RobotLocomotion:master Jan 12, 2018
@jwnimmer-tri jwnimmer-tri deleted the bazel-reuse-workspace-pr6 branch January 12, 2018 17:47
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soonho-tri soonho-tri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwnimmer-tri @jamiesnape @soonho-tri