Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drake-distro from example READMEs #7886

Merged
merged 2 commits into from
Jan 30, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 27, 2018

This also makes valkyrie_pd_ff_controller executable again -- we'd been compiling it as a library ever since we switched to Bazel. As it turns out, its a main program split into header + cc.

Relates #6996.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@amcastro-tri could I ask you to feature-review this cleanup, please?

@amcastro-tri
Copy link
Contributor

Thanks for the cleanup @jwnimmer-tri. :lgtm:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


systems/sensors/test/accelerometer_test/README.md, line 3 at r1 (raw file):

To run a demo of an accelerometer attached to a pendulum:

# When building Drake using Bazel

BTW this comment is probably not needed anymore.


Comments from Reviewable

@amcastro-tri
Copy link
Contributor

+@sammy-tri for platform review please.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

Review status: all files reviewed at latest revision, 1 unresolved discussion.


systems/sensors/test/accelerometer_test/README.md, line 3 at r1 (raw file):

Previously, amcastro-tri (Alejandro Castro) wrote…

BTW this comment is probably not needed anymore.

Actually users can and do still use CMake builds. https://github.com/RobotLocomotion/drake/blob/master/CMakeLists.txt


Comments from Reviewable

@sammy-tri
Copy link
Contributor

:lgtm:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit cac9809 into RobotLocomotion:master Jan 30, 2018
@jwnimmer-tri jwnimmer-tri deleted the doc-distro-examples branch January 30, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants