Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove //drake prefix from build_components.bzl #8172

Merged
merged 1 commit into from
Feb 25, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 25, 2018

This is just a search-replace, not human-written changes.

This defers fixing the regeneration script to a future commit (PR #8073), but in the meantime removes a misleading prefix and should make it more clear when we do repair the regeneration script what lines have been added or removed in that commit.

Relates #6996.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@RussTedrake for all review please, if you are around today.

This is just a search-replace, not human-written changes.

This defers fixing the regeneration script to a future commit, but in
the meantime removes a misleading prefix and should make it more clear
when we *do* repair the regeneration script what lines have been added
or removed in that commit.
@RussTedrake
Copy link
Contributor

:lgtm: i'm not sure that I deeply understand the implications, but the edits look like they should reasonably break everything (especially in the pydrake tests) or nothing. i'm convinced.


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit 7fa5929 into RobotLocomotion:master Feb 25, 2018
@jwnimmer-tri jwnimmer-tri deleted the 6996-libdrake branch February 25, 2018 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants