numpy_dtype_user: Pave way for downstream libs to define user dtypes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2018
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
2 times, most recently
from
524c2b7 to
11250dc
Compare
EricCousineau-TRI
force-pushed
the
drake
branch
from
3dcfcb0 to
1151a8a
Compare
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
7 times, most recently
from
ae0beaa to
e33c5ff
Compare
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
from
e33c5ff to
6d90c77
Compare
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
3 times, most recently
from
824a89b to
e712b18
Compare
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
3 times, most recently
from
35fbeb8 to
3a4d863
Compare
1 task
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
2 times, most recently
from
2cccd6b to
906b5f2
Compare
EricCousineau-TRI
changed the title
EricCousineau-TRI
force-pushed
the
feature/numpy_dtype_user
branch
from
906b5f2 to
7b4c254
Compare
|
Closing (3 yrs old) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, this PR builds and runs in Bazel, but segfaults in CMake:
https://github.com/EricCousineau-TRI/repro/blob/0993f47d027e7e5f3212e55b5c658f9b600b3152/python/pybind11/BUILD#L225-L237
Will fix that tomorrow.
Relates RobotLocomotion/drake#8315 RobotLocomotion/drake#8116
\cc @m-chaturvedi @soonho-tri @RussTedrake
Related upstream PRs:
dtype(...).numpybind/pybind11#1329 - ensuring theint64_tmatches toNPY_INT64This change is