Skip to content

operators: Expose meta information #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Mar 16, 2018

To more easily facilitate RobotLocomotion/drake#8389

Cherry-picked from #12

@soonho-tri Would you be OK with reviewing this?


This change is Reviewable

@soonho-tri
Copy link
Member

:lgtm:

The changes are seemingly harmless, but at the same time we do not utilize info in this PR, yet. But I guess we will do in the future PRs?


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@EricCousineau-TRI
Copy link
Collaborator Author

Yup, it's used in #12, and I'll use it now in #8389 (hopefully before this PR merges, so it can be validated upstream).


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@soonho-tri
Copy link
Member

BTW, reviewable website allowed me to review this PR via its interface which is nice. But I guess it's not fully integrated yet as Github still asks me to provide a review.

Do you plan to enable reviewable workflow here?

@soonho-tri
Copy link
Member

I'll use it now in #8389

Nice!

@EricCousineau-TRI
Copy link
Collaborator Author

I'm a little tentative to do so (not sure how it will affect TravisCI), but can consider it.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@soonho-tri
Copy link
Member

No rush. Just my wish.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@EricCousineau-TRI
Copy link
Collaborator Author

Given that RobotLocomotion/drake#8389 did not even needs this, I'm going to go ahead close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants