chore: Merge 4.69.0 into single-server#6966
Conversation
* fix: formatting base64 images wrong * chore: add base64 avatar storybook case * chore: improve unit tests of getAvatarUrl * chore: format code and fix lint issues [skip ci] * fix: unit test * cleanup --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com>
* fix: hide elements instead of conditional render * chore: update snapshot test * fix: remove useMemo * chore: add case on storybook * fix: snapshot test * chore: format code and fix lint issues [skip ci] --------- Co-authored-by: OtavioStasiak <OtavioStasiak@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. WalkthroughVersion is downgraded from 4.69.0 to 4.68.2 across build files and manifests. Firebase configuration files are removed. Server initialization logic is refactored to use a single hardcoded server from app.json instead of dynamic discovery. The NewServerView navigation screen is disabled, and the rooms list header loses interactive functionality. Changes
Sequence DiagramsequenceDiagram
participant AppInit as App Init<br/>(initSaga)
participant AppConfig as appConfig<br/>(app.json)
participant Storage as Local Storage
participant Server as Server Action
participant AppState as App State
rect rgba(100, 150, 200, 0.5)
Note over AppInit: Old Flow - Dynamic Discovery
AppInit->>Storage: Read CURRENT_SERVER
Storage-->>AppInit: (legacy server data)
AppInit->>Storage: Query servers DB
Storage-->>AppInit: Multiple servers
AppInit->>AppState: selectServerRequest(servers[...])
end
rect rgba(150, 200, 100, 0.5)
Note over AppInit: New Flow - Single Server Config
AppInit->>AppConfig: Read server URL
AppConfig-->>AppInit: https://open.rocket.chat
AppInit->>Storage: Read userId for this server
alt userId found
Storage-->>AppInit: userId
AppInit->>AppState: selectServerRequest(server, version)
else userId not found
Storage-->>AppInit: null
AppInit->>Server: serverRequest(appConfig.server)
Server-->>AppInit: initiated
AppInit->>AppState: appStart(ROOT_OUTSIDE)
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Bug Fixes
Chores