[FIX] Auto Translate not working on new message template #27317

filipemarins · 2022-11-22T13:57:11Z

Proposed changes (including videos or screenshots)

Fix auto translate not working on new message template;
Fix a bug that the auto-translate icon was showing for users who didn't have enabled.
Show translated quote messages;
Remove translation provider for end users.
Translate the ThreadMessagePreview component

Issue(s)

Steps to test or reproduce

Further comments

I had to move useAutoTranslate and useKatex to a separate hook cause on MessageList component the context isn't fulfilled yet.

Quote attachment

Multilevel quote attachments get translated as well:

But if you try to translate a message that wasn't translated yet and has multiple levels of quote message it will only translate the first quote message...

ThreadMessagePreview component translated

lgtm-com · 2022-11-22T14:15:58Z

This pull request introduces 1 alert when merging b90ea63 into b816803 - view on LGTM.com

new alerts:

1 for Syntax error

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

gabriellsh

When sending an attachment, the description was not translated in the main room, but was in the thread.

packages/core-typings/src/IMessage/IMessage.ts

packages/core-typings/src/IMessage/MessageAttachment/MessageAttachmentBase.ts

apps/meteor/client/views/room/MessageList/hooks/useAutoTranslate.ts

apps/meteor/client/views/room/MessageList/components/ThreadMessagePreviewBody.tsx

apps/meteor/client/views/room/MessageList/hooks/useMessages.ts

apps/meteor/app/autotranslate/client/lib/actionButton.ts

apps/meteor/app/autotranslate/server/autotranslate.ts

codecov · 2022-11-22T19:34:22Z

Codecov Report

Merging #27317 (f0c0b16) into develop (69c7248) will decrease coverage by 0.02%.
The diff coverage is 47.76%.

@@             Coverage Diff             @@
##           develop   #27317      +/-   ##
===========================================
- Coverage    42.90%   42.88%   -0.03%     
===========================================
  Files          814      817       +3     
  Lines        17199    17234      +35     
  Branches      1923     1934      +11     
===========================================
+ Hits          7380     7391      +11     
- Misses        9563     9579      +16     
- Partials       256      264       +8

Flag	Coverage Δ
e2e	`42.88% <47.76%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

filipemarins · 2022-11-23T12:37:36Z

When sending an attachment, the description was not translated in the main room, but was in the thread.

Inside the thread, we are having the wrong behavior, we should not translate our own message. I was only focused on the main message list but nice catch, I will fix it on the thread.

gabriellsh

Since this is a very large PR on an important feature, I'll ask for an additional review.

…te attachment

…g translated

apps/meteor/client/components/message/content/attachments/file/AudioAttachment.tsx

apps/meteor/client/components/message/variants/ThreadMessage.tsx

apps/meteor/client/components/message/variants/ThreadMessagePreview.tsx

apps/meteor/client/views/room/MessageList/MessageList.tsx

apps/meteor/client/views/room/MessageList/hooks/useMessages.ts

apps/meteor/app/autotranslate/client/lib/actionButton.ts

packages/core-typings/src/IMessage/MessageAttachment/TranslatedMessageAttachment.ts

apps/meteor/client/views/room/contextualBar/Threads/components/ThreadMessageList.tsx

apps/meteor/client/views/room/MessageList/MessageList.tsx

apps/meteor/client/views/room/MessageList/lib/parseMessageTextToAstMarkdown.ts

apps/meteor/client/views/room/MessageList/hooks/useMessages.ts

apps/meteor/client/views/room/MessageList/hooks/useAutoTranslate.ts

apps/meteor/client/views/room/MessageList/hooks/useMessageBody.tsx

apps/meteor/client/components/message/variants/ThreadMessagePreview.tsx

changes made

…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Show different labels based on the call originator on direct calls (#27729) Chore: Change bundle tags color and refactor app details page header styles (#27293) [FIX] Auto Translate not working on new message template (#27317) Chore: Custom Sounds Empty State (#27632) [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556) Regression: Broken room and message composer events (#27754) [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699) [IMPROVE] SAML and OAuth role sync to support id and name (#27405) Chore: add e2e test coverage for Video Conference (#27075) Chore: Invites Empty State (#27631) [FIX] Marketplace app status initially disabled (#27330) Regression: Missing contexts on contextual bar (#27734)

* matrixSearch: First iteration Chore: Show different labels based on the call originator on direct calls (#27729) Chore: Change bundle tags color and refactor app details page header styles (#27293) [FIX] Auto Translate not working on new message template (#27317) the commit.

dionisio-bot bot added the stat: needs QA label Nov 22, 2022

filipemarins force-pushed the tc-223 branch from 411c243 to b90ea63 Compare November 22, 2022 13:58

filipemarins force-pushed the tc-223 branch 2 times, most recently from 244e91a to 6d1f466 Compare November 22, 2022 15:29

filipemarins marked this pull request as ready for review November 22, 2022 15:29

filipemarins requested review from a team as code owners November 22, 2022 15:29

filipemarins added the squad: team-collab label Nov 22, 2022

gabriellsh requested changes Nov 22, 2022

View reviewed changes

gabriellsh previously approved these changes Nov 24, 2022

View reviewed changes

filipemarins dismissed gabriellsh’s stale review via d405f19 November 25, 2022 15:40

filipemarins added 12 commits November 25, 2022 12:40

chore: remove auto translate provider

7adeaae

refactor: move katex and auto translate to external hook

73249c8

refactor: remove quote link before send message to translate and upda…

2d0ea28

…te attachment

chore: update types

1159f34

refactor: fix translated not parsed and parse attachments

0d374ea

refactor: replace the way how remove link

656d408

refactor: remove translation provider for old template

77bf54b

refactor: add translated message attachment

1202bf7

refactor: add helper to check translation and fix thread message bein…

6ce5a2f

…g translated

refactor: remove duplicated call of parse message function

e33e432

refactor: fix types

0f3b5e6

refactor: udpate conditionals

a5135a4

filipemarins force-pushed the tc-223 branch from d405f19 to a5135a4 Compare November 25, 2022 15:40

hugocostadev added 2 commits December 7, 2022 10:48

Merge branch 'develop' into tc-223

6e00733

fix lint errors

2661aa6

hugocostadev previously approved these changes Dec 7, 2022

View reviewed changes

Merge branch 'develop' into tc-223

611697a

gabriellsh previously requested changes Jan 4, 2023

View reviewed changes

hugocostadev added 2 commits January 5, 2023 10:28

Merge branch 'develop' into tc-223

dbccd66

fix: unused codes and eslint rules

478fdb4

hugocostadev added this to the 6.0.0 milestone Jan 9, 2023

tassoevan requested changes Jan 9, 2023

View reviewed changes

hugocostadev added 2 commits January 9, 2023 14:05

Merge remote-tracking branch 'origin/develop' into tc-223

dc1d4d0

Merge remote-tracking branch 'origin/develop' into tc-223

5e7a8ee

casalsgh requested review from a team January 10, 2023 18:06

hugocostadev added 2 commits January 11, 2023 10:52

refactoring change requested

e207245

Merge remote-tracking branch 'origin/develop' into tc-223

42bf3dd

tassoevan previously approved these changes Jan 12, 2023

View reviewed changes

hugocostadev added the stat: QA tested label Jan 16, 2023

dionisio-bot bot added stat: conflict and removed stat: needs QA labels Jan 16, 2023

Merge remote-tracking branch 'origin/develop' into tc-223

f0c0b16

hugocostadev dismissed tassoevan’s stale review via f0c0b16 January 16, 2023 17:16

dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Jan 16, 2023

tassoevan approved these changes Jan 16, 2023

View reviewed changes

kodiakhq bot merged commit c420e99 into develop Jan 16, 2023

kodiakhq bot deleted the tc-223 branch January 16, 2023 18:38

sampaiodiego mentioned this pull request Feb 17, 2023

Release 6.0.0 #28084

Merged

sampaiodiego mentioned this pull request Mar 9, 2023

Release 6.0.0 #28345

Merged

13 tasks

This was referenced Mar 10, 2023

Auto-translate: Translations are not displayed #27949

Closed

Automatic translation has a bug #28232

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] Auto Translate not working on new message template #27317

[FIX] Auto Translate not working on new message template #27317

filipemarins commented Nov 22, 2022 •

edited by hugocostadev

Loading

lgtm-com bot commented Nov 22, 2022

gabriellsh left a comment

codecov bot commented Nov 22, 2022 •

edited

Loading

filipemarins commented Nov 23, 2022

gabriellsh left a comment

[FIX] Auto Translate not working on new message template #27317

[FIX] Auto Translate not working on new message template #27317

Conversation

filipemarins commented Nov 22, 2022 • edited by hugocostadev Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

lgtm-com bot commented Nov 22, 2022

gabriellsh left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 22, 2022 • edited Loading

Codecov Report

filipemarins commented Nov 23, 2022

gabriellsh left a comment

Choose a reason for hiding this comment

filipemarins commented Nov 22, 2022 •

edited by hugocostadev

Loading

codecov bot commented Nov 22, 2022 •

edited

Loading