Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add e2e test coverage for Video Conference #27075

Merged
merged 37 commits into from
Jan 13, 2023
Merged

Conversation

weslley543
Copy link
Contributor

@weslley543 weslley543 commented Oct 14, 2022

add some tests for video conference

Proposed changes (including videos or screenshots)

Jira Issue: VC-49

Issue(s)

Steps to test or reproduce

Further comments

@weslley543 weslley543 changed the title test: add test for video conference Chore: add test for video conference Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #27075 (113cf33) into develop (303e836) will increase coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27075      +/-   ##
===========================================
+ Coverage    41.57%   42.99%   +1.41%     
===========================================
  Files          841      814      -27     
  Lines        17706    17189     -517     
  Branches      1996     1921      -75     
===========================================
+ Hits          7362     7390      +28     
+ Misses       10102     9542     -560     
- Partials       242      257      +15     
Flag Coverage Δ
e2e 42.99% <ø> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

weslley543 and others added 23 commits October 17, 2022 13:32
Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
Heroku app.json file needs to be in root folder
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
@dougfabris dougfabris changed the title Chore: add test for video conference Chore: add e2e test coverage for Video Conference Nov 24, 2022
@dougfabris dougfabris self-assigned this Nov 24, 2022
@dougfabris dougfabris added this to the 5.4.0 milestone Nov 30, 2022
@alvaropmello alvaropmello modified the milestones: 5.4.0, 6.0.0 Dec 7, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 23, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 10, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 10, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Jan 11, 2023
@kodiakhq kodiakhq bot merged commit c1e3da2 into develop Jan 13, 2023
@kodiakhq kodiakhq bot deleted the test/video-conference branch January 13, 2023 14:09
gabriellsh added a commit that referenced this pull request Jan 16, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Show different labels based on the call originator on direct calls (#27729)
  Chore: Change bundle tags color and refactor app details page header styles (#27293)
  [FIX] Auto Translate not working on new message template (#27317)
  Chore: Custom Sounds Empty State (#27632)
  [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556)
  Regression: Broken room and message composer events (#27754)
  [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699)
  [IMPROVE] SAML and OAuth role sync to support id and name (#27405)
  Chore: add e2e test coverage for Video Conference (#27075)
  Chore: Invites Empty State (#27631)
  [FIX] Marketplace app status initially disabled (#27330)
  Regression: Missing contexts on contextual bar (#27734)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.