Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Broken room and message composer events #27754

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It hotfixes two issues:

  1. user card not opening on clicking in user mentions;
  2. slash commands inside threads sending results to the main room.

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #27754 (24419cd) into develop (28dc859) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27754      +/-   ##
===========================================
- Coverage    43.05%   42.99%   -0.06%     
===========================================
  Files          814      814              
  Lines        17189    17189              
  Branches      1921     1921              
===========================================
- Hits          7401     7391      -10     
- Misses        9526     9542      +16     
+ Partials       262      256       -6     
Flag Coverage Δ
e2e 42.99% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review January 14, 2023 15:12
@tassoevan tassoevan requested a review from a team as a code owner January 14, 2023 15:12
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 14, 2023
@kodiakhq kodiakhq bot merged commit 0c53e9d into develop Jan 14, 2023
@kodiakhq kodiakhq bot deleted the regression/room-and-composer-events branch January 14, 2023 15:25
gabriellsh added a commit that referenced this pull request Jan 16, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Show different labels based on the call originator on direct calls (#27729)
  Chore: Change bundle tags color and refactor app details page header styles (#27293)
  [FIX] Auto Translate not working on new message template (#27317)
  Chore: Custom Sounds Empty State (#27632)
  [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556)
  Regression: Broken room and message composer events (#27754)
  [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699)
  [IMPROVE] SAML and OAuth role sync to support id and name (#27405)
  Chore: add e2e test coverage for Video Conference (#27075)
  Chore: Invites Empty State (#27631)
  [FIX] Marketplace app status initially disabled (#27330)
  Regression: Missing contexts on contextual bar (#27734)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants