fix: Infinite loading when uploading a private app #33181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f55b0dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33181 +/- ##
========================================
Coverage 59.73% 59.73%
========================================
Files 2548 2548
Lines 63073 63073
Branches 14090 14090
========================================
Hits 37679 37679
Misses 22978 22978
Partials 2416 2416
Flags with carried forward coverage won't be shown. Click here to find out more. |
MartinSchoeler
changed the title
dougfabris
requested changes
Aug 29, 2024
dionisio-bot
bot
added
stat: ready to merge
MartinSchoeler
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
MartinSchoeler
added
the
stat: ready to merge
|
gabriellsh
added a commit
that referenced
this pull request
Sep 11, 2024
…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Infinite loading when uploading a private app (#33181) chore: publish preview github pages (#33248) chore: move playground (#33260) chore: E2EE setting warning update (#33224) fix: message parser being slow to process very long messages with too many symbols (#33227) chore: fix ui-playground build (#33250) feat: Option to disable 2FA for OAuth users (#32945) fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes issue that causes infinite loading due an uncatched error when uploading invalid zip files
Fixes issue that causes infinite loading when opening a upsell modal
Issue(s)
PASLR-1
Steps to test or reproduce
Further comments