Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ui-playground build #33250

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: fix ui-playground build #33250

merged 1 commit into from
Sep 11, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 10, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: f509d84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.79%. Comparing base (0f21fa0) to head (f509d84).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33250   +/-   ##
========================================
  Coverage    59.79%   59.79%           
========================================
  Files         2548     2548           
  Lines        63412    63412           
  Branches     14267    14267           
========================================
  Hits         37920    37920           
  Misses       23076    23076           
  Partials      2416     2416           
Flag Coverage Δ
unit 76.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review September 10, 2024 23:44
@ggazzo ggazzo added this to the 6.13 milestone Sep 11, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@ggazzo ggazzo removed the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 6730a3c into develop Sep 11, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the chore/ui-playground branch September 11, 2024 00:19
gabriellsh added a commit that referenced this pull request Sep 11, 2024
…hAvatarById

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Infinite loading when uploading a private app (#33181)
  chore: publish preview github pages (#33248)
  chore: move playground (#33260)
  chore: E2EE setting warning update (#33224)
  fix: message parser being slow to process very long messages with too many symbols (#33227)
  chore: fix ui-playground build (#33250)
  feat: Option to disable 2FA for OAuth users (#32945)
  fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants