Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: E2EE setting warning update #33224

Merged
merged 3 commits into from
Sep 11, 2024
Merged

chore: E2EE setting warning update #33224

merged 3 commits into from
Sep 11, 2024

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

The warning related to E2EE must be updated, given the new features we are including in 6.10;

It was removed:

  • The mobile apps may not support the encrypted messages (they are implementing it).
  • Uploads will not be encrypted in this version.

image

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-34

@hugocostadev hugocostadev added this to the 6.13 milestone Sep 6, 2024
Copy link
Contributor

dionisio-bot bot commented Sep 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: b0f1f92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (79c16d3) to head (b0f1f92).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33224   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2548     2548           
  Lines        63073    63073           
  Branches     14090    14090           
========================================
  Hits         37679    37679           
  Misses       22978    22978           
  Partials      2416     2416           
Flag Coverage Δ
unit 76.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review September 6, 2024 18:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 2497616 into develop Sep 11, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the chore/warning-update branch September 11, 2024 13:28
gabriellsh added a commit that referenced this pull request Sep 11, 2024
…hAvatarById

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Infinite loading when uploading a private app (#33181)
  chore: publish preview github pages (#33248)
  chore: move playground (#33260)
  chore: E2EE setting warning update (#33224)
  fix: message parser being slow to process very long messages with too many symbols (#33227)
  chore: fix ui-playground build (#33250)
  feat: Option to disable 2FA for OAuth users (#32945)
  fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants