Azure App Service PAAS deployment #65

theprash · 2018-04-26T15:57:25Z

Adds ARM template and Azure deployment to FAKE script for #51.

I needed to introduce an environment variable to allow changing the public content path because the Azure deployment I was using required putting the server at the root.

This depends on #64.

isaacabraham · 2018-04-26T17:33:45Z

Closes #51

theimowski · 2018-04-26T21:04:17Z

Content/.template.config/template.json

@@ -81,6 +81,12 @@
      "dataType": "bool",
      "defaultValue": "false",
      "description": "use NPM instead of default Yarn for JS package management"
+    },
+    "Azure": {


How about introducing a choice parameter, say "Deploy" with two options for now: Docker and Azure - both options do not have much sense if combined

That makes sense to me as well.

Agreed. I've made that change.

theimowski · 2018-04-26T21:05:20Z

Content/arm-template.json

+            "sku": { "name": "F1" },
+            "name": "[variables('appServicePlan')]",
+            "apiVersion": "2016-09-01",
+            "location": "West Europe"


I have no experience with ARM but wondering whether all of the options here, like location should be hard-coded?

The SKU and Location can both be parameterised (the Location definitely). @theprash The script is already using the Region type, which contains consts for all Azure regions, for the deployment object so you can use that as a means to supply this as an input parameter to the template. The SKU I don't think is available in code - this template has an example of showing the different SKUs available and how to set them as input values.

I've added a pricingTier parameter for the SKU.

theimowski · 2018-04-26T21:06:30Z

Content/src/Server/Server.fsproj

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk.Web">


What's the difference?

With the Web version, you get a web.config file which is used by IIS / Azure App Service to start up the application through dotnet and to pass through traffic from IIS to the app.

So that would be applicable only to Azure option? Should this be a conditional then?

I thought this would've been conditional, yes. @theprash thoughts?

@theimowski @isaacabraham, I thought it might be better to avoid a conditional branch on the project type just to reduce complexity a little bit if there's little or no downside in using the .Web version for all versions of the template. Aside from the web.config file, it also adds some extra entries in Server.deps.json which seem to not be very important, but I don't know what they're for.

I'm happy to make it conditional though...?

OK I've done it 😀

theimowski · 2018-04-26T21:07:16Z

Content/build.fsx

+  client.UploadData(destinationUri, IO.File.ReadAllBytes zipFile) |> ignore
+)
+
+"Publish" ==> "DeployWebApp"


Can we put that into a single chain?

Technically this is what the dependencies are (the ARM deploy only sets up Azure infrastructure) but @isaacabraham has already put them in a single chain and I'm happy with it.

theimowski · 2018-04-26T21:07:27Z

Content/build.fsx

@@ -124,6 +186,11 @@ Target "Docker" (fun _ ->
  ==> "Docker"
 #endif

+#if (Azure)
+"Clean" ==> "Publish" ==> "DeployWebApp"


theimowski · 2018-04-26T21:07:49Z

Started reviewing, but didn't yet manage to test myself

Simplify FAKE chain. Improve error reporting for missing ARM arguments.

# Conflicts: # Content/build.fsx # Content/src/Server/ServerGiraffe.fs # Content/src/Server/ServerSaturn.fs # Content/src/Server/ServerSuave.fs

theimowski · 2018-04-27T12:57:38Z

Content/.template.config/template.json

@@ -125,11 +138,15 @@
          "condition": "(Fulma != \"login\")"
        },
        {
-          "exclude": "**/Dockerfile",
+          "exclude": "Dockerfile",
          "condition": "(!Docker)"


the condition should now change to "(Deploy != \"docker\")"

Whoops I missed those. Fix now, thanks.

theimowski · 2018-04-27T12:58:14Z

Content/.template.config/template.json

          "condition": "(!Docker)"
        },
        {
-          "exclude": "**/yarn.lock",
+          "exclude": "arm-template.json",
+          "condition": "(!Azure)"


similar to above

theimowski · 2018-04-27T13:20:24Z

Content/build.fsx

+  let armTemplate = @"arm-template.json"
+  let resourceGroupName = "safe-" + environment
+  let subscriptionId = try getBuildParam "subscriptionId" |> Guid.Parse with _ -> failwith "Invalid Subscription ID. This should be your Azure Subscription ID."
+  let clientId = try getBuildParam "clientId" |> Guid.Parse with _ -> failwith "Invalid Client ID. This should be the Client ID of a Native application registered in Azure with permission to create resources in your subscription."


How do I generate clientId? Create a "Web App" in azure then what?

This needs to be documented properly but you need to create an app in Active Directory, set it to "Native" and then give it permissions to Windows Azure. The application id is the client id you need to use.

theimowski · 2018-04-27T13:27:10Z

Is the public_path env var a must?

isaacabraham · 2018-04-27T13:42:57Z

@theimowski what should we use instead? Environment variables usually work quite well across most systems I imagine.

theprash · 2018-04-27T13:50:40Z

@theimowski, We needed to be able to configure the public folder path in order for the Azure deploy to work, at least with the method that we're using here. The server had to be at the root of the published folder so it could not refer to a "Client" directory outside of itself. I discussed with @isaacabraham a few different ways we could do this including adding a config file, which is not well supported yet by FAKE for .NET Core. We thought an environment variable would be the least intrusive method for now. It can be set easily for the app in Azure and other systems as Isaac mentioned above.

theimowski · 2018-04-27T13:50:44Z

Sorry I didn't make myself clear. I meant to ask if its required to have any variance for the public_path and if so why's that?

theimowski · 2018-04-27T13:52:04Z

Ok thanks, then again I'd it in for making that conditional just for azure option

isaacabraham · 2018-04-27T14:00:43Z

Yeah. We could've deployed both the "client" and "server" folders as now but that makes things somewhat more complicated in terms of build / packaging I think. Perhaps we'll revisit this in the future but for now I think what is here should work (apart from your comment about making the environment bit Azure-only - I think that we can do that.)

… Docker).

isaacabraham · 2018-04-28T14:16:41Z

@theimowski I've now created a (lengthy) guide on the docs site in the template-deployment branch. Can you give it a run through and see if it works / makes sense for you? We can then release this alongside that.

isaacabraham · 2018-04-28T17:41:07Z

I've now also added support for Suave, which is hosted in App Service slightly differently than Giraffe.

theimowski · 2018-04-28T21:01:29Z

I'll have a look on Tuesday

…ite to the Trace output though.

theimowski · 2018-05-01T07:26:09Z

Content/.template.config/template.json

@@ -150,7 +181,8 @@
          }
        }
      ]
-    },"**/*.fsx": {
+    },
+    "**/*.fs*": {


is this change intentional?

I can see you also now use //#if instead of #if in .fsx script - is that this change that allowed that? Maybe we can get rid of this entry completely then?

@theprash one for you.

This change was required to enable templating in the FSPROJ file. I believe the entry is still required for FSX too. The commenting of #if was not related to this change.

Right, makes sense. So you commented #if in fsx for better editor support? I think I like it this way now

theimowski · 2018-05-01T07:57:05Z

I started testing the appservice target and run into some dll hell issue after entering the code to browser:

Finished Target: Bundle
Starting Target: ArmTemplate (==> Bundle)
Deploying template 'arm-template.json' to resource group 'safe-795cba0b' in subscription '{subscriptionId}'...
Redirect assembly from 'System.Net.Http, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' to 'System.Net.Http, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code {code} to authenticate.
Running build failed.
Error:
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.
File name: 'Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
   at Microsoft.Azure.Management.ResourceManager.Fluent.ResourceManager.Authenticated..ctor(RestClient restClient)
   at FSI_0005.Cit.Helpers.Arm.authenticateDevice@128-2.Invoke(AuthenticationResult _arg2)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.args@825-1.Invoke(a a)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.FSharp.Control.AsyncBuilderImpl.commit[a](AsyncImplResult`1 res)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronouslyInCurrentThread[a](CancellationToken token, FSharpAsync`1 computation)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronously[a](CancellationToken token, FSharpAsync`1 computation, FSharpOption`1 timeout)
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken)
   at FSI_0005.Build.clo@89-12.Invoke(Unit _arg1)
   at Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in D:\code\fake\src\app\FakeLib\TargetHelper.fs:line 626

Assembly manager loaded from:  C:\Windows\Microsoft.NET\Framework\v4.0.30319\clr.dll
Running under executable  %home%\sandbox\test\packages\build\FAKE\tools\FAKE.exe
--- A detailed error log follows.

=== Pre-bind state information ===
LOG: DisplayName = Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35
 (Fully-specified)
LOG: Appbase = file:///%home%/sandbox/test/packages/build/FAKE/tools/
LOG: Initial PrivatePath = NULL
Calling assembly : Microsoft.Azure.Management.ResourceManager.Fluent, Version=1.0.0.60, Culture=neutral, PublicKeyToken=31bf3856ad364e35.
===
LOG: This bind starts in LoadFrom load context.
WRN: Native image will not be probed in LoadFrom context. Native image will only be probed in default load context, like with Assembly.Load().
LOG: Using application configuration file: %home%\sandbox\test\packages\build\FAKE\tools\FAKE.exe.Config
LOG: Using host configuration file:
LOG: Using machine configuration file from C:\Windows\Microsoft.NET\Framework\v4.0.30319\config\machine.config.
LOG: Post-policy reference: Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/FAKE/tools/Microsoft.Rest.ClientRuntime.Azure.DLL.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/FAKE/tools/Microsoft.Rest.ClientRuntime.Azure/Microsoft.Rest.ClientRuntime.Azure.DLL.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/FAKE/tools/Microsoft.Rest.ClientRuntime.Azure.EXE.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/FAKE/tools/Microsoft.Rest.ClientRuntime.Azure/Microsoft.Rest.ClientRuntime.Azure.EXE.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/Microsoft.Azure.Management.ResourceManager.Fluent/lib/netstandard1.3/Microsoft.Rest.ClientRuntime.Azure.DLL.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/Microsoft.Azure.Management.ResourceManager.Fluent/lib/netstandard1.3/Microsoft.Rest.ClientRuntime.Azure/Microsoft.Rest.ClientRuntime.Azure.DLL.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/Microsoft.Azure.Management.ResourceManager.Fluent/lib/netstandard1.3/Microsoft.Rest.ClientRuntime.Azure.EXE.
LOG: Attempting download of new URL file:///%home%/sandbox/test/packages/build/Microsoft.Azure.Management.ResourceManager.Fluent/lib/netstandard1.3/Microsoft.Rest.ClientRuntime.Azure/Microsoft.Rest.ClientRuntime.Azure.EXE.


---------------------------------------------------------------------
Build Time Report
---------------------------------------------------------------------
Target              Duration
------              --------
Clean               00:00:00.1522493
InstallDotNetCore   00:00:00.1603336
InstallClient       00:00:02.2953899
Build               00:00:20.5715311
Bundle              00:00:03.3486279
ArmTemplate         Failure
Total:              00:01:24.0550037
---------------------------------------------------------------------
Status:             Failure
---------------------------------------------------------------------
---------------------------------------------------------------------

Not the binding redirect for System.Net.Http at the beginning - not sure if that's desired?

isaacabraham · 2018-05-01T08:06:03Z

@theimowski The binding redirect with System.Net.Http is a red herring here I think. I've seen this issue this weekend with Microsoft.Rest.ClientRuntime.Azure. The "fix" is (and don't laugh) to make a change to the FAKE script e.g. add a new line anywhere in the script, and then re-run it. It then works.

I have no idea why this is happening or how to prevent it from occurring in the first place.

theimowski · 2018-05-01T08:10:39Z

WTF, do we know why's that? If not the "fix" should be documented for sure

isaacabraham · 2018-05-01T08:19:58Z

@theimowski I have no idea. Can you test it - maybe it just happens on my machine!

isaacabraham · 2018-05-01T08:37:21Z

I'm also considering moving away from the SDK and shelling out to the az command line tool instead (and we would install that during the fake script).

theimowski · 2018-05-01T09:03:28Z

Yes it worked :) Something FAKE-related? @matthid any ideas why resaving a fake script may have impact on assembly binding? This is using FAKE 4

matthid · 2018-05-01T09:07:16Z

So does this happen again after that and you need to make another change or does it always work now?

theimowski · 2018-05-01T09:13:07Z

Works now without need to make more changes. The Redirect assembly from 'System.Net.Http warning is still there, but works anyway

matthid · 2018-05-01T09:30:52Z

No idea, so it is not reproduce-able at all?

theimowski · 2018-05-01T09:33:17Z

LGTM - I managed to deploy Saturn and Suave versions to azure.
Awesome work, huge props @theprash and @isaacabraham !

Can we add a note to docs about the FAKE modify-file "fix" until we know what's the real issue here?

matthid · 2018-05-01T09:34:31Z

Can we add a note to docs about the FAKE modify-file "fix" until we know what's the real issue here?

Or upgrade to latest version of fake ;)

theimowski · 2018-05-01T09:37:04Z

Yes that's probably a good idea anyway - added #70

theimowski · 2018-05-01T09:37:36Z

This is now released in 0.15
Thanks again

jarlestabell · 2018-05-01T16:29:27Z

Amazing work, thanks! :)
BTW: I also got the Could not load file or assembly 'Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0... error at first and applied the fix (dummy edit of the Fake script). And then it worked.

isaacabraham · 2018-05-01T16:39:55Z

@jarlestabell yeah. It's annoying - hopefully moving to FAKE 5 will "fix" this, but we don't know exactly why it's happening :-/

theprash added 4 commits April 25, 2018 14:05

Update Paket.Restore.targets

44b764c

Move all static content to "public" dir

217a58b

#51 Azure deployment

2fc4174

Use dotnetCli variable

84c5801

isaacabraham mentioned this pull request Apr 26, 2018

Put all static content inside the public dir #64

Merged

isaacabraham changed the title ~~Azure deployment~~ Azure App Service PAAS deployment Apr 26, 2018

theimowski reviewed Apr 26, 2018

View reviewed changes

isaacabraham and others added 4 commits April 27, 2018 11:26

Make ARM deployment location a parameter.

032c0e5

Simplify FAKE chain. Improve error reporting for missing ARM arguments.

Merge branch 'master' into azure-deploy

ea20bbb

# Conflicts: # Content/build.fsx # Content/src/Server/ServerGiraffe.fs # Content/src/Server/ServerSaturn.fs # Content/src/Server/ServerSuave.fs

"Deploy" parameter with docker and azure options

8151c63

Comment template conditionals for better tooling support

90c6981

theimowski reviewed Apr 27, 2018

View reviewed changes

Add Azure pricingTier parameter to build script

8f68176

theprash and others added 2 commits April 27, 2018 14:31

Fix deploy parameter conditions

88dd727

Temporarily turn on DefaultFiles() (pending Saturn PR).

4562ff9

Merge branch 'fix-static-content' into azure-deploy

5ee9c39

Small cleanup of Azure elements in build script (and consistency with…

204e23f

… Docker).

isaacabraham added 3 commits April 28, 2018 19:08

Work on Suave support.

2c3f27a

Final change.

5917fb8

Fix web.config getting deployed incorrectly.

13d6c2b

isaacabraham added 2 commits April 29, 2018 10:12

Work on adding Trace Listeners to Suave on Azure.

7a9cede

Start Trace Listener. Still need to figure out how to get Suave to wr…

eb1912c

…ite to the Trace output though.

theimowski reviewed May 1, 2018

View reviewed changes

theimowski merged commit fe17e18 into SAFE-Stack:master May 1, 2018

theimowski mentioned this pull request May 1, 2018

Add ARM template and routine for Azure deployment #51

Closed

theprash deleted the azure-deploy branch May 1, 2018 10:18

theimowski mentioned this pull request Jun 21, 2018

Dotnet 2.1 and FAKE 5 #101

Merged

theimowski mentioned this pull request Aug 31, 2018

Server: should Microsoft.NET.Sdk.Web be used? #153

Closed

Azure App Service PAAS deployment #65

Azure App Service PAAS deployment #65

Conversation

theprash commented Apr 26, 2018

isaacabraham commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theimowski commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theimowski commented Apr 27, 2018

isaacabraham commented Apr 27, 2018

theprash commented Apr 27, 2018

theimowski commented Apr 27, 2018

theimowski commented Apr 27, 2018

isaacabraham commented Apr 27, 2018

isaacabraham commented Apr 28, 2018

isaacabraham commented Apr 28, 2018

theimowski commented Apr 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theimowski commented May 1, 2018 • edited Loading

isaacabraham commented May 1, 2018

theimowski commented May 1, 2018

isaacabraham commented May 1, 2018

isaacabraham commented May 1, 2018

theimowski commented May 1, 2018

matthid commented May 1, 2018

theimowski commented May 1, 2018

matthid commented May 1, 2018

theimowski commented May 1, 2018

matthid commented May 1, 2018

theimowski commented May 1, 2018

theimowski commented May 1, 2018

jarlestabell commented May 1, 2018

isaacabraham commented May 1, 2018

theimowski commented May 1, 2018 •

edited

Loading