Fix input validation in fiddle idpmock #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
zarkosimic
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus and
pekura
as code owners
# Conflicts: # website/fiddle/package-lock.json
maxmarkus
reviewed
May 5, 2020
| window.location.href.match(/post_logout_redirect_uri=(.*?)(&|$)/)[1] | ||
| ); | ||
| window.location.href = redirectTo; | ||
| const disableJs = redirectTo.replace(/javascript:/gi, ''); |
There was a problem hiding this comment.
I am not sure if this is enough, since there are tons of possibilities how one could write javascript according to https://owasp.org/www-community/xss-filter-evasion-cheatsheet .. But since we are checking if it starts with window.location.origin I couldn't find a possibility to sneak anything in. Just thinking if we remove that check at all just not to raise wrong safety feelings.
There was a problem hiding this comment.
I would say it's fine.
I tested:
`http://localhost:8080/auth/idpmock/logout.html?post_logout_redirect_uri=javascript:alert("XSS")
http://localhost:8080/auth/idpmock/logout.html?post_logout_redirect_uri=JaVaScRiPt:alert('XSS')
http://localhost:8080/auth/idpmock/logout.html?post_logout_redirect_uri=javascript:alert('XSS');
http://localhost:8080/auth/idpmock/logout.html?post_logout_redirect_uri=javascript:alert("RSnake says, 'XSS'")`
All of them aren't working.
We can think if we apply the last point in the issue description and replace window.location.origin with the fiddle url but I think we can also do the implemented version.
JohannesDoberer
approved these changes
May 8, 2020
maxmarkus
approved these changes
May 12, 2020
JohannesDoberer
added a commit
that referenced
this pull request
May 20, 2020
* master: Migrate setup scripts to v1 (#1325) Add pre commit hook (#1344) Update npm dependencies in luigi-landingpage (#1346) Added read-only keyword labels to documentation (#1313) Cleanup the mock login page (#1340) Enable nightly builds (#1334) Fix input validation in fiddle idpmock (#1309) change travis to fix only on push to master (#1338) added selected state (#1326) Migrate example apps to v1 (#1311) Provide config in JS format to Fiddle e2e tests (#1305) Add Youtube section to the landing page and Documentation (#1315) Add a note about loadingIndicator to pageErrorHandler (#1310) Run compatibility tests in ci (#1307) Add possibility to unload Luigi (#1304)
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
May 20, 2020
* master: Enable nightly builds (SAP#1334) Fix input validation in fiddle idpmock (SAP#1309) change travis to fix only on push to master (SAP#1338) added selected state (SAP#1326) Migrate example apps to v1 (SAP#1311) Provide config in JS format to Fiddle e2e tests (SAP#1305) Add Youtube section to the landing page and Documentation (SAP#1315) Add a note about loadingIndicator to pageErrorHandler (SAP#1310) Run compatibility tests in ci (SAP#1307) Add possibility to unload Luigi (SAP#1304)
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
May 20, 2020
* feature-globalsearch: Migrate setup scripts to v1 (SAP#1325) Add pre commit hook (SAP#1344) Update npm dependencies in luigi-landingpage (SAP#1346) Added read-only keyword labels to documentation (SAP#1313) Cleanup the mock login page (SAP#1340) Enable nightly builds (SAP#1334) Fix input validation in fiddle idpmock (SAP#1309) change travis to fix only on push to master (SAP#1338) added selected state (SAP#1326) Migrate example apps to v1 (SAP#1311) Provide config in JS format to Fiddle e2e tests (SAP#1305) Add Youtube section to the landing page and Documentation (SAP#1315) Add a note about loadingIndicator to pageErrorHandler (SAP#1310) Run compatibility tests in ci (SAP#1307) Add possibility to unload Luigi (SAP#1304)
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
May 20, 2020
* search-provider-interface: Migrate setup scripts to v1 (SAP#1325) Add pre commit hook (SAP#1344) Update npm dependencies in luigi-landingpage (SAP#1346) Added read-only keyword labels to documentation (SAP#1313) Cleanup the mock login page (SAP#1340) Enable nightly builds (SAP#1334) Fix input validation in fiddle idpmock (SAP#1309) change travis to fix only on push to master (SAP#1338) added selected state (SAP#1326) Migrate example apps to v1 (SAP#1311) Provide config in JS format to Fiddle e2e tests (SAP#1305) Add Youtube section to the landing page and Documentation (SAP#1315) Add a note about loadingIndicator to pageErrorHandler (SAP#1310) Run compatibility tests in ci (SAP#1307) Add possibility to unload Luigi (SAP#1304)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1290