Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the mock login page #1340

Merged
merged 7 commits into from
May 19, 2020
Merged

Cleanup the mock login page #1340

merged 7 commits into from
May 19, 2020

Conversation

UlianaMunich
Copy link
Contributor

@UlianaMunich UlianaMunich commented May 15, 2020 •
edited
Loading

Fixes #1294

  • add fundamental styles to the mock login
  • cleanup/rename
  • update mobile view

@UlianaMunich UlianaMunich changed the title cleanup the mocked login page Cleanup the mocked login page May 15, 2020
@maxmarkus maxmarkus changed the title Cleanup the mocked login page Cleanup the mock login page May 18, 2020
@maxmarkus maxmarkus self-assigned this May 18, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 10 milestone May 18, 2020
@ndricimrr ndricimrr self-assigned this May 18, 2020
ndricimrr
ndricimrr approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works and looks very well 👍

maxmarkus
maxmarkus approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@UlianaMunich UlianaMunich merged commit 2d86dc6 into SAP:master May 19, 2020
@UlianaMunich UlianaMunich deleted the 1294-restyle-login-mock-page branch May 19, 2020 07:49
JohannesDoberer added a commit that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
ff7deb6 
* master:
  Migrate setup scripts to v1 (#1325)
  Add pre commit hook (#1344)
  Update npm dependencies in luigi-landingpage (#1346)
  Added read-only keyword labels to documentation (#1313)
  Cleanup the mock login page (#1340)
  Enable nightly builds (#1334)
  Fix input validation in fiddle idpmock (#1309)
  change travis to fix only on push to master (#1338)
  added selected state (#1326)
  Migrate example apps to v1 (#1311)
  Provide config in JS format to Fiddle e2e tests (#1305)
  Add Youtube section to the landing page and Documentation (#1315)
  Add a note about loadingIndicator to pageErrorHandler  (#1310)
  Run compatibility tests in ci (#1307)
  Add possibility to unload Luigi (#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'feature-globalsearch' of github.com:SAP/luigi into feat…
6291902 
…ure-globalsearch

* 'feature-globalsearch' of github.com:SAP/luigi:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'feature-globalsearch' into search-provider-interface
3297aa9 
* feature-globalsearch:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'search-provider-interface' into closeSearchField
b350ad4 
* search-provider-interface:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
@ndricimrr ndricimrr added the refactoring Something needs to be refactored in a separate task label Jun 4, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich @maxmarkus
Cleanup the mock login page (SAP#1340)
3b25455 
* style login-mock.hrml according to Fuundamental Styles 0.8.1

Co-authored-by: Markus <1720843+maxmarkus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@pekura pekura Awaiting requested review from pekura

@zarkosimic zarkosimic Awaiting requested review from zarkosimic

Assignees

@maxmarkus maxmarkus

@ndricimrr ndricimrr

Labels
refactoring Something needs to be refactored in a separate task
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging this pull request may close these issues.

Update Luigi Log in page (FD Styles v0.8.1)
4 participants
@UlianaMunich @maxmarkus @ndricimrr @JohannesDoberer