Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm dependencies in luigi-landingpage #1346

Merged
merged 5 commits into from
May 19, 2020
Merged

Update npm dependencies in luigi-landingpage #1346

merged 5 commits into from
May 19, 2020

Conversation

zarkosimic
Copy link
Contributor

Fixes #1330

@zarkosimic zarkosimic added security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 follow up Follow up tasks security always set in addition to specific security severity label, since github filtering is lacking OR labels May 18, 2020
@zarkosimic zarkosimic added this to the Sprint 10 milestone May 18, 2020
@JohannesDoberer JohannesDoberer self-assigned this May 18, 2020
@ndricimrr ndricimrr self-assigned this May 18, 2020
JohannesDoberer
JohannesDoberer approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zarkosimic zarkosimic merged commit d58292e into SAP:master May 19, 2020
@zarkosimic zarkosimic deleted the 1330_update_npm_dependencies_in_luigi_landingpage branch May 19, 2020 10:13
JohannesDoberer added a commit that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
ff7deb6 
* master:
  Migrate setup scripts to v1 (#1325)
  Add pre commit hook (#1344)
  Update npm dependencies in luigi-landingpage (#1346)
  Added read-only keyword labels to documentation (#1313)
  Cleanup the mock login page (#1340)
  Enable nightly builds (#1334)
  Fix input validation in fiddle idpmock (#1309)
  change travis to fix only on push to master (#1338)
  added selected state (#1326)
  Migrate example apps to v1 (#1311)
  Provide config in JS format to Fiddle e2e tests (#1305)
  Add Youtube section to the landing page and Documentation (#1315)
  Add a note about loadingIndicator to pageErrorHandler  (#1310)
  Run compatibility tests in ci (#1307)
  Add possibility to unload Luigi (#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'feature-globalsearch' of github.com:SAP/luigi into feat…
6291902 
…ure-globalsearch

* 'feature-globalsearch' of github.com:SAP/luigi:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'feature-globalsearch' into search-provider-interface
3297aa9 
* feature-globalsearch:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 20, 2020
@JohannesDoberer
Merge branch 'search-provider-interface' into closeSearchField
b350ad4 
* search-provider-interface:
  Migrate setup scripts to v1 (SAP#1325)
  Add pre commit hook (SAP#1344)
  Update npm dependencies in luigi-landingpage (SAP#1346)
  Added read-only keyword labels to documentation (SAP#1313)
  Cleanup the mock login page (SAP#1340)
  Enable nightly builds (SAP#1334)
  Fix input validation in fiddle idpmock (SAP#1309)
  change travis to fix only on push to master (SAP#1338)
  added selected state (SAP#1326)
  Migrate example apps to v1 (SAP#1311)
  Provide config in JS format to Fiddle e2e tests (SAP#1305)
  Add Youtube section to the landing page and Documentation (SAP#1315)
  Add a note about loadingIndicator to pageErrorHandler  (SAP#1310)
  Run compatibility tests in ci (SAP#1307)
  Add possibility to unload Luigi (SAP#1304)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@zarkosimic
Update npm dependencies in luigi-landingpage (SAP#1346)
66b24ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

Assignees

@JohannesDoberer JohannesDoberer

@ndricimrr ndricimrr

Labels
follow up Follow up tasks security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 security always set in addition to specific security severity label, since github filtering is lacking OR
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging this pull request may close these issues.

Update npm dependencies in luigi-landingpage
4 participants
@zarkosimic @JohannesDoberer @ndricimrr @UlianaMunich