fix(ui5-select): fix popover opening (#2687)

When the accessibility refactoring of was done the focus reference was changed. The click event should focus the correct element so the internal rules which controls the visibility of value state could pass. Fixes: #2682
SAP · Jan 15, 2021 · 53418fb · 53418fb
1 parent a442dbf
commit 53418fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/main/src/Select.hbs b/packages/main/src/Select.hbs
@@ -2,9 +2,10 @@
 	class="ui5-select-root"
 	dir="{{effectiveDir}}"
 	id="{{_id}}-select"
-	@click="{{_toggleRespPopover}}"
+	@click="{{_onclick}}"
 >
 	<div class="ui5-select-label-root"
+		data-sap-focus-ref
 		tabindex="{{tabIndex}}"
 		role="combobox"
 		aria-haspopup="listbox"

diff --git a/packages/main/src/Select.js b/packages/main/src/Select.js
@@ -456,6 +456,11 @@ class Select extends UI5Element {
 		this._toggleRespPopover();
 	}
 
+	_onclick(event) {
+		this.getFocusDomRef().focus();
+		this._toggleRespPopover();
+	}
+
 	/**
 	 * The user used arrow up/down on the list
 	 * @private