fix(ui5-select): fix popover opening #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Jan 14, 2021
| @@ -456,6 +456,15 @@ class Select extends UI5Element { | |||
| this._toggleRespPopover(); | |||
| } | |||
|
|
|||
| _onclick(event) { | |||
| this.getFocusDomRef().focus(); | |||
There was a problem hiding this comment.
There is getFocusDomRef() in UI5Element.js line 687, you can just set data-sap-focus-ref attr to the "{id}-label" and the UI5Element#getFocusDomRef will return it.
ilhan007
approved these changes
Jan 15, 2021
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
When the accessibility refactoring of was done the focus reference was changed. The click event should focus the correct element so the internal rules which controls the visibility of value state could pass. Fixes: SAP#2682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the accessibility refactoring of was done the focus reference was changed. The click event should focus the correct element so the internal rules which controls the visibility of value state could pass.
Fixes: #2682