Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-select does not close on click when there is value state #2682

Closed
vladitasev opened this issue Jan 14, 2021 · 0 comments · Fixed by #2687
Closed

ui5-select does not close on click when there is value state #2682

vladitasev opened this issue Jan 14, 2021 · 0 comments · Fixed by #2687
Assignees
@nnaydenow
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@vladitasev
Copy link
Contributor

vladitasev commented Jan 14, 2021 •
edited
Loading

On master:
Try the following:

<ui5-select value-state="Information">
	<ui5-option icon="accept">Cozy</ui5-option>
	<ui5-option icon="accept" selected>Compact</ui5-option>
	<ui5-option icon="accept">Condensed</ui5-option>
</ui5-select>

Click on any item that is not selected. The select will close and open again very fast (looks like it never closes). Clicking on the already selected option is fine.

Now delete the value-state attribute - no matter on which item you click, it works well (select closes on click).
@vladitasev vladitasev changed the title ui5-select does not close on click when there is value state ui5-select does not close on click when there is value state Jan 14, 2021
@nnaydenow nnaydenow self-assigned this Jan 14, 2021
@nnaydenow nnaydenow added bug This issue is a bug in the code Medium Prio labels Jan 14, 2021
@nnaydenow nnaydenow added TOPIC P and removed TOPIC B labels Jan 14, 2021
@nnaydenow nnaydenow mentioned this issue Jan 14, 2021
Merged
nnaydenow added a commit that referenced this issue Jan 15, 2021
@nnaydenow
fix(ui5-select): fix popover opening (#2687)
53418fb 
When the accessibility refactoring of was done the focus reference was changed. The click event should focus the correct element so the internal rules which controls the visibility of value state could pass.

Fixes: #2682
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
@nnaydenow @NHristov-sap
fix(ui5-select): fix popover opening (SAP#2687)
888bd1f 
When the accessibility refactoring of was done the focus reference was changed. The click event should focus the correct element so the internal rules which controls the visibility of value state could pass.

Fixes: SAP#2682
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnaydenow nnaydenow

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-select): fix popover opening
3 participants
@ilhan007 @vladitasev @nnaydenow