-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-menu): adjust menu and sub-menu creation #8367
Conversation
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: SAP#7767 Fixes: SAP#7423 Fixes: SAP#6761 Related to: SAP#7391
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
Now when hovering with mouse on a menu with busy indicator, the focus goes to busy indicator.
We have arrow back in main menu on mobile view.
One from me: on mobile view, there is a focus on disabled items, please check. |
The focus appears on an actual mobile device on item press. The same behavior was also reproducible before this change |
Those two cases are now handled properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to select the first item.(Space, Enter or Mouse click). Is that something with the sample or an issue?
The default behavior for the menu item is prevented at application level. I've improved the tooltip and menu item texts, in order to give detail about the item selection as we've discussed. |
- The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations. - There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device. Fixes: #7767 Fixes: #7423 Fixes: #6761
The ui5-menu elements used for sub-menus are created only once and are being reused afterwards. They are no longer destroyed on close. This contributes to lowering the count of the slow DOM manipulation operations.
There is now no differentiation between mobile and desktop device in regards to the display mechanism. In both cases we rely on the template to do the job as the components used for composition like ui5-list and ui5-responsive-popover do comply with the device.
Fixes: #7767
Fixes: #7423
Fixes: #6761